Skip to content

Update user playlist view to show grab bar disabled when items being deleted - #9515

Open
PikachuEXE wants to merge 3 commits into
FreeTubeApp:developmentfrom
PikachuEXE:feature/show-grab-bar-disabled
Open

Update user playlist view to show grab bar disabled when items being deleted#9515
PikachuEXE wants to merge 3 commits into
FreeTubeApp:developmentfrom
PikachuEXE:feature/show-grab-bar-disabled

Conversation

@PikachuEXE

Copy link
Copy Markdown
Member

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

#9468 (comment) (already closed, but the suggestion is from a comment on the issue

Description

Wondering if it would be possible to make it less visually disruptive though, like maybe just greying out the drag symbol rather than having the whole element disappear and have everything jump around?

This PR makes grab bar remain visible but disabled (this is about grid mode only, list mode unchanged)

Screenshots

Screen.Recording.2026-07-28.at.18.37.14.mp4

Testing

  • Set Video View Type to Grid
  • Spawn a user playlist with 3+ items
  • Remove an item
  • Ensure grab bar still visible and look disabled and cannot be dragged

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 28, 2026 10:43
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things i noticed.

The first one is that the user can drag the grab bar when its disabled. Im not sure if we need todo anything about this though.

Second, grab bar shouldnt be available when there is only one video in playlist

VirtualBoxVM_q2pYuYg5Gl.mp4

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jul 28, 2026
@PikachuEXE

Copy link
Copy Markdown
Member Author

Fixed grab bar draggable when disabled (unnecessary change from me)
However for grab bar it seems more consistent to show grab bar on custom sort regardless of no. of videos (just like when videos being deleted

@Shadorc

Shadorc commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

I've tested the MR with different scenarios and it works fine

I would tend to say that disabling the grab bar would have made sense if the drop-down sort menu was always displayed. It would have indicated that, indeed it's a custom sort, but you can't sort one video.
With the "Sort By" dropdown being hidden with one video, it feels more natural to also hide the grab bar.

@PikachuEXE

Copy link
Copy Markdown
Member Author

Did not test playlist with 1 items only
Now grab bar hidden like sort control

@Shadorc

Shadorc commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

LGTM!

@efb4f5ff-1298-471a-8973-3d47447115dc

Copy link
Copy Markdown
Member

Should we enforce the same behavior in list mode to keep the UX consistent?

@PikachuEXE

Copy link
Copy Markdown
Member Author

I think this PR is necessary to avoid the jumping around thing, not on list mode side
And user can't use both mode at the same time...

#9468 (comment)

Wondering if it would be possible to make it less visually disruptive though, like maybe just greying out the drag symbol rather than having the whole element disappear and have everything jump around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: waiting for review For PRs that are complete, tested, and ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants