Skip to content

WIP: Fix loading comment replies - #9555

Draft
CL-Jeremy wants to merge 2 commits into
FreeTubeApp:developmentfrom
CL-Jeremy:ytjs18-fix-replies
Draft

WIP: Fix loading comment replies#9555
CL-Jeremy wants to merge 2 commits into
FreeTubeApp:developmentfrom
CL-Jeremy:ytjs18-fix-replies

Conversation

@CL-Jeremy

Copy link
Copy Markdown

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #9474.

Description

This PR fixes makes use of the recent feature update of upstream YouTube.js Edge version to quickly fix fetching replies. Since upstream will most probably publish a release (v18?) soon-ish, I'm putting this here as a starter (based on the discussion at LuanRT/YouTube.js#1214, see additional context below). Upstream has nested replies ready so that could be implemented later (design choices have to be made).

Screenshots

Testing

Open any video with comments and try to load them. Replies should also work.

Desktop

  • OS: macOS
  • OS Version: 15.7.8
  • FreeTube version: 0.25.1 Beta

Additional context

  • pnpm-related changes are obviously provisional and will be changed as soon as the next YouTube.js release lands.
  • While loading comments now requires a full session (in order to get sub-threads) just like getting video info, the session is bound to the initial comment request, so continuations should still be fast. Note the session is reused between continuations of the same comment thread request, i. e. one per video page refresh. Question is whether that should be of concern.

Signed-off-by: Mike L <cl.jeremy@qq.com>
Signed-off-by: Mike L <cl.jeremy@qq.com>
@CL-Jeremy
CL-Jeremy force-pushed the ytjs18-fix-replies branch from 77a0633 to 83a4cdd Compare August 3, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Comments not loading

1 participant