Fix XcodeGen project drift#793
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerate the committed Xcode project so it includes
OllamaPreloadWorkControllerTests.swift, matching theCotabbyTestsdirectory declared byproject.yml. This restores the XcodeGen drift gate onmainafter the compatibility revert removed the generated test reference.Validation
xcodegen generatetwice; the second generation produced byte-identical project outputswiftlint lint --quiet; exit 0xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' build -derivedDataPath build/DerivedData; BUILD SUCCEEDEDxcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' build-for-testing -derivedDataPath build/DerivedData; TEST BUILD SUCCEEDEDLinked issues
None.
Risk / rollout notes
Generated-project-only change. It restores one existing test file to the
CotabbyTeststarget and does not change production runtime behavior.Greptile Summary
This PR regenerates the committed Xcode project to restore
OllamaPreloadWorkControllerTests.swiftto theCotabbyTeststarget after a compatibility revert dropped the generated reference. The file exists on disk atCotabbyTests/OllamaPreloadWorkControllerTests.swiftand is covered by thepath: CotabbyTestsdeclaration inproject.yml.project.pbxproj: aPBXFileReference, a group child entry, aPBXBuildFile, and aSourcesbuild phase reference — all with unique UUIDs and correct cross-references.Confidence Score: 5/5
Safe to merge — only adds the missing test file reference back to the generated project, with no changes to production code.
The change is purely regenerated project scaffolding. The test file already exists on disk and is declared in project.yml; the four new PBX entries are structurally correct with unique UUIDs and consistent cross-references. No production logic, build settings, or existing entries are touched.
No files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[project.yml\nCotabbyTests source: CotabbyTests/] --> B[xcodegen generate] B --> C[project.pbxproj] C --> D{OllamaPreloadWorkControllerTests.swift\nreferenced?} D -- Before PR: NO --> E[XcodeGen drift gate fails\nTest file on disk but not in target] D -- After PR: YES --> F[CotabbyTests target\nincludes all sources] F --> G[Drift gate passes\nBuild & test succeed]%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A[project.yml\nCotabbyTests source: CotabbyTests/] --> B[xcodegen generate] B --> C[project.pbxproj] C --> D{OllamaPreloadWorkControllerTests.swift\nreferenced?} D -- Before PR: NO --> E[XcodeGen drift gate fails\nTest file on disk but not in target] D -- After PR: YES --> F[CotabbyTests target\nincludes all sources] F --> G[Drift gate passes\nBuild & test succeed]Reviews (1): Last reviewed commit: "Fix XcodeGen project drift" | Re-trigger Greptile