Repository navigation
fix(ui): resolve 13 native desktop usability audit findings - #3539
Merged
Merged
Conversation
bobleer
force-pushed
the
bob/uiux-audit-fixes
branch
2 times, most recently
from
October 23, 2026 13:43
6a8bcfb to
d9c335a
Compare
bobleer
force-pushed
the
bob/uiux-audit-fixes
branch
from
October 23, 2026 15:52
d9c335a to
9e16ddc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 13 findings from the native desktop UI/UX audit, with one commit per finding. Empty and failed states now explain what happened and offer valid next steps; settings, search, calendar and agent creation are accessible and consistent with the active locale and host.
randomUUID.Type and Areas
Bug fix / UI/UX. Shared design-system controls, Web UI, mobile duration presentation and i18n documentation. No Rust runtime, persisted identifier, or wire-protocol changes.
Motivation / Impact
These changes address the selected audit findings together while keeping each reviewable and revertible in its own commit. Host actions continue through existing transport/service owners. Legacy shortcut settings and agent IDs remain readable; user-authored quick-action labels are preserved.
Verification
AI-assisted; tested locally with automated coverage and native macOS debug verification. Live remote/device end-to-end coverage is not claimed.
9e16ddc3d10f86c65ba482111ca181c706b1d7f9: frontend lint/build, 1,075 Web UI test files with 12,092 passing tests, mobile checks, and the three-platform Rust/CLI matrix. Repository Object Sizes also passed; impact-unselected jobs were skipped by the existing workflow.pnpm run check:web— passed after native QA fixes and again after integrating upstream fix(ui): remove Git panel entry points and shortcuts #3538.pnpm run i18n:audit— passed, zero warnings.pnpm run theme:color-audit:all— passed; no baseline increases.pnpm --dir src/web-ui exec node scripts/run-vitest.mjs run …— all 28 changed test files passed, 346 tests. Additional focused navigation, terminal bridge, project creation, field controls, localization and icon tests passed during implementation.pnpm --dir src/mobile-web exec tsc --noEmitandpnpm --dir src/mobile-web run test:ui-components— passed; 18 UI tests.pnpm --dir src/web-ui run icons:checkand the icon/startup tests — passed.node scripts/check-git-object-sizes.mjs --base upstream/main --head HEADandgit diff --check— passed.pnpm installandpnpm run desktop:devafter the 13 initial fixes; the Rust debug build completed. Native QA used that same debug binary in a local app bundle with the Vite dev server and isolated development storage.block-beta/flowchart plus invalid Mermaid, localized quick actions and task agents, appearance copy, and agent creation/template/save/reopen with fixed existing ID.Remote scenarios: remote-workspace unsupported states/routing and Peer Device activation fences are covered with local fixtures, not live hosts. Mobile presentation was type-checked and component-tested, not exercised through live Remote Connect. Detached Dispatch protocol/runtime behavior is unchanged and was not exercised live.
Reviewer Notes
The optional full
pnpm run design-system:checkcurrently fails two pre-existing flow-chat catalog parity tests (AgentDelete/AgentInterruptregistry mismatch andTask/AgentControl/ListWorkspacespresentation catalog coverage). Both were reproduced on the unmodified base checkout; focused shared-control tests passed. No assertions or audit baselines were weakened.The Git native verification above predates upstream #3538, which retired its standalone panel entry points during CI. This PR preserves that retirement and tests the retained component without restoring navigation.
Native before/after evidence is retained locally with the UI audit and verification captures. The PR does not add generated screenshots or temporary process artifacts to the repository.
Checklist