Repository navigation
fix(mobile-web): keep model selection scoped to remote sessions - #3544
Open
BingCHuanJ wants to merge 2 commits into
Open
BingCHuanJ wants to merge 2 commits into
BingCHuanJ wants to merge 2 commits into
Conversation
Co-authored-by: OpenBitFun <318544290+bitfun-ai@users.noreply.github.com>
Co-authored-by: OpenBitFun <318544290+bitfun-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes mobile web session model selection so switching sessions restores the model and reasoning settings saved by the selected host session instead of reusing a browser-wide preference.
Type and Areas
Type: bug fix
Areas: mobile web, remote connect, Rust core, desktop/CLI adapters, CI
Motivation / Impact
When a user changed the model in one remote session and then switched to another session in mobile web, the selected model could remain from the previous session instead of following the target session's saved configuration.
This change makes mobile web follow the same per-session behavior as the main application.
Verification
pnpm --dir src/mobile-web run test:session-model-browser— 56/56 passedcargo check --offline --locked -p openbitfun-cli --bin openbitfun— passedpnpm --dir src/mobile-web exec vite build— passedpnpm run i18n:audit— passedpnpm run check:core-boundaries— passedpnpm run check:repo-hygiene— passedReviewer Notes
Browser coverage uses an isolated Chromium profile and covers modern and legacy hosts, session switching, stale responses, timed-out writes, cancellation, device changes, account isolation, and narrow layouts.
The local full Desktop check was blocked before Rust compilation by the missing generated file
src/apps/extension-host/dist/extension-host.js. No related feature test failed.Checklist