Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3959 +/- ##
===========================================
- Coverage 58.89% 58.89% -0.01%
===========================================
Files 1353 1353
Lines 113035 113065 +30
===========================================
+ Hits 66573 66589 +16
- Misses 46462 46476 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
herve-gross
approved these changes
Feb 4, 2026
OmarDuran
approved these changes
Feb 6, 2026
jhuang2601
approved these changes
Apr 10, 2026
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: dkachuma <81433670+dkachuma@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a reference thermal conductivity field distinct from the computed effective thermal conductivity, enabling per-cell import (e.g., from VTK) without being overwritten by model initialization (Issue #3956).
Changes:
- Add
referenceThermalConductivityas a writable/readable constitutive field and expose it through schema. - Update
SinglePhaseThermalConductivityto computeeffectiveConductivityfrom the reference field (plus temperature gradient). - Add an integrated test case that imports
referenceThermalConductivityfrom a VTK mesh and rebaseline integrated tests accordingly.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreComponents/schema/schema.xsd.other | Adds schema attribute for referenceThermalConductivity. |
| src/coreComponents/constitutive/thermalConductivity/ThermalConductivityFields.hpp | Declares the new referenceThermalConductivity field trait. |
| src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivityBase.hpp | Extends base update/state with reference conductivity and adds initializeState() hook. |
| src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivityBase.cpp | Registers/allocates the new field. |
| src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivity.hpp | Wires the reference field into the kernel wrapper + adds initialization overrides. |
| src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivity.cpp | Implements initialization and uses reference conductivity in state setup and temperature updates. |
| src/coreComponents/physicsSolvers/surfaceGeneration/SurfaceGenerator.cpp | Initializes thermal conductivity state for newly created fracture elements. |
| src/coreComponents/physicsSolvers/surfaceGeneration/EmbeddedSurfaceGenerator.cpp | Initializes thermal conductivity state for newly created embedded-surface elements. |
| inputFiles/singlePhaseWell/thermal_compressible_single_phase_wells_1d.xml | New integrated test input importing reference conductivity from VTK. |
| inputFiles/singlePhaseWell/singlePhaseWell.ats | Registers the new integrated test deck. |
| inputFiles/singlePhaseWell/mesh_1d.vtr | Adds VTK mesh (Git LFS) containing conductivity field for import. |
| inputFiles/singlePhaseWell/.gitattributes | Ensures the VTK mesh is tracked via Git LFS. |
| .integrated_tests.yaml | Points CI integrated tests at the updated baseline bundle. |
| BASELINE_NOTES.md | Adds a baseline note entry for this baseline update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a reference thermal conductivity. The point of this is that the user might want this to be read from the vtk file for example. So we separate this from the effective thermal conductivity which is the calculated output from the thermal conductivity model.
#3956
Rebaseline to fix errors of type
which is expected because this change introduces this new wrapper.