Skip to content

feat: Add reference thermal conductivity#3959

Open
dkachuma wants to merge 30 commits intodevelopfrom
dkachuma/reference-thermal-conductivity
Open

feat: Add reference thermal conductivity#3959
dkachuma wants to merge 30 commits intodevelopfrom
dkachuma/reference-thermal-conductivity

Conversation

@dkachuma
Copy link
Copy Markdown
Contributor

@dkachuma dkachuma commented Feb 3, 2026

Adds a reference thermal conductivity. The point of this is that the user might want this to be read from the vtk file for example. So we separate this from the effective thermal conductivity which is the calculated output from the thermal conductivity model.

#3956

Rebaseline to fix errors of type

********************************************************************************
Error: /Problem/domain/MeshBodies/mesh1/meshLevels/Level0/ElementRegions/elementRegionsGroup/region/elementSubRegions/cb
	Group has a child 'thermalCond_linear_referenceThermalConductivity' in the file to compare but not the baseline file.
********************************************************************************

which is expected because this change introduces this new wrapper.

@dkachuma dkachuma self-assigned this Feb 3, 2026
@dkachuma dkachuma added type: feature New feature or request ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: requires rebaseline Requires rebaseline branch in integratedTests ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Feb 3, 2026
@dkachuma dkachuma requested a review from sytuannguyen February 3, 2026 18:14
@dkachuma dkachuma linked an issue Feb 3, 2026 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 63.15789% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.89%. Comparing base (5abf149) to head (8513525).

Files with missing lines Patch % Lines
...malConductivity/SinglePhaseThermalConductivity.cpp 84.00% 4 Missing ⚠️
...ers/surfaceGeneration/EmbeddedSurfaceGenerator.cpp 0.00% 4 Missing ⚠️
...sicsSolvers/surfaceGeneration/SurfaceGenerator.cpp 0.00% 4 Missing ⚠️
...onductivity/SinglePhaseThermalConductivityBase.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3959      +/-   ##
===========================================
- Coverage    58.89%   58.89%   -0.01%     
===========================================
  Files         1353     1353              
  Lines       113035   113065      +30     
===========================================
+ Hits         66573    66589      +16     
- Misses       46462    46476      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@OmarDuran OmarDuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkachuma thank you for your contribution. The modifications in the SurfaceGenerators look good.

@dkachuma
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Co-authored-by: dkachuma <81433670+dkachuma@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI commented Apr 14, 2026

@copilot resolve the merge conflicts in this pull request

Resolved and pushed in commit b9a4e48. I merged latest origin/develop, fixed the merge conflicts in .integrated_tests.yaml and BASELINE_NOTES.md, and finalized the merge commit.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a reference thermal conductivity field distinct from the computed effective thermal conductivity, enabling per-cell import (e.g., from VTK) without being overwritten by model initialization (Issue #3956).

Changes:

  • Add referenceThermalConductivity as a writable/readable constitutive field and expose it through schema.
  • Update SinglePhaseThermalConductivity to compute effectiveConductivity from the reference field (plus temperature gradient).
  • Add an integrated test case that imports referenceThermalConductivity from a VTK mesh and rebaseline integrated tests accordingly.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
src/coreComponents/schema/schema.xsd.other Adds schema attribute for referenceThermalConductivity.
src/coreComponents/constitutive/thermalConductivity/ThermalConductivityFields.hpp Declares the new referenceThermalConductivity field trait.
src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivityBase.hpp Extends base update/state with reference conductivity and adds initializeState() hook.
src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivityBase.cpp Registers/allocates the new field.
src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivity.hpp Wires the reference field into the kernel wrapper + adds initialization overrides.
src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivity.cpp Implements initialization and uses reference conductivity in state setup and temperature updates.
src/coreComponents/physicsSolvers/surfaceGeneration/SurfaceGenerator.cpp Initializes thermal conductivity state for newly created fracture elements.
src/coreComponents/physicsSolvers/surfaceGeneration/EmbeddedSurfaceGenerator.cpp Initializes thermal conductivity state for newly created embedded-surface elements.
inputFiles/singlePhaseWell/thermal_compressible_single_phase_wells_1d.xml New integrated test input importing reference conductivity from VTK.
inputFiles/singlePhaseWell/singlePhaseWell.ats Registers the new integrated test deck.
inputFiles/singlePhaseWell/mesh_1d.vtr Adds VTK mesh (Git LFS) containing conductivity field for import.
inputFiles/singlePhaseWell/.gitattributes Ensures the VTK mesh is tracked via Git LFS.
.integrated_tests.yaml Points CI integrated tests at the updated baseline bundle.
BASELINE_NOTES.md Adds a baseline note entry for this baseline update.

Comment thread src/coreComponents/physicsSolvers/surfaceGeneration/EmbeddedSurfaceGenerator.cpp Outdated
Comment thread inputFiles/singlePhaseWell/singlePhaseWell.ats Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import thermal conductivity fails on ThermalSinglePhaseFluid

6 participants