feat: Adding flow statistics for arbitrary mesh cell element sets#4005
Open
MelReyCG wants to merge 38 commits intobugfix/rey/split-statistics-componentsfrom
Open
feat: Adding flow statistics for arbitrary mesh cell element sets#4005MelReyCG wants to merge 38 commits intobugfix/rey/split-statistics-componentsfrom
MelReyCG wants to merge 38 commits intobugfix/rey/split-statistics-componentsfrom
Conversation
…onents' into feature/rey/arbitrary-regions-stats
…onents' into feature/rey/arbitrary-regions-stats
…y/arbitrary-regions-stats
MelReyCG
requested review from
herve-gross,
jhuang2601 and
rrsettgast
as code owners
MelReyCG
changed the title
…nor string_view replacement)
MelReyCG
changed the title
dkachuma
approved these changes
Apr 6, 2026
Contributor
dkachuma
left a comment
dkachuma
left a comment
There was a problem hiding this comment.
Very useful feature.
But I would keep it simple and have a single output for each statistics node i.e. only report the statistics for all the selected sets. This would keep the csv simple and directly loadable with numpy for plotting. If the user wants statistics for another set, they can add another statistics xml element.
- Add an inError parameter to basicCleanup, cleanupEnvironment, finalizeMPI, and MpiWrapper::finalize to distinguish normal vs. error shutdown and adjusting MPI finalization behavior, preventing any MPI infinite hanging. - Avoid normal MPI finalization/reporting on error paths (terminate via the error handler instead) to prevent collective/finalize hangs. - Update main entrypoints and a broad set of unit/integration tests to use the new cleanup signatures.
…onents' into feature/rey/arbitrary-regions-stats
MelReyCG
added
the
flag: requires rebaseline
* Refactored importNodesets * Update dfn_market meshes * Uncrustify * Replace bitwise AND with equality check
* Add ConstitutiveDriver base class * Restore reactive fluid file * Change documentation * Fix rst * Remove reactive driver tests * Fix ats file * Add step_check to test cases * Rebaseline * Copilot comments * Update PR #3883 entry with new date and link * Update baseline path in integrated tests configuration
* wip: balance compilation time and memory usage for MFD kernels * Trigger CI pipeline
* Add Poisson's ratio and Young's modulus to register data fields * Delete comments * Change logs * regenerate schema after adding youngModulus/poissonRatio fields to ElasticIsotropic * Uncrustify * Rebaseline --------- Co-authored-by: Jian Huang <53012159+jhuang2601@users.noreply.github.com> Co-authored-by: dkachuma <dickkachuma@googlemail.com>
…ary-regions-stats
MelReyCG
requested review from
bd713,
corbett5,
cssherman,
jafranc and
wrtobin
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at extending the flow statistics components by introducing an optional
setNamesparameter toSinglePhaseStatisticsandCompositionalMultiphaseStatistics, allowing users to obtain statistics computation from arbitrary mesh element sets instead of being forced to process solver regions.Sets can already be defined with
Geometryobjects likeBox.Multiple set can be provided for a given statistics component, and in that case, statistics over all provided sets are also logged. To support intersecting sets and give valid statistics, they are computed on a compound set (union of all selected set).
Here is an example:
The infrastructure proposed here can be re-used for new statistics components which would process cell elements, and is implemented at the
StatisticsAggregatorBaselevel, introduced in the PR #3836 .The parameter has been used in the
simpleCo2InjTutorialexample to test that functionnality.