ci: add Windows build to release workflow (NSIS .exe + MSI .msi)#11
Open
LocallyInsaneDB wants to merge 1 commit into
Open
ci: add Windows build to release workflow (NSIS .exe + MSI .msi)#11LocallyInsaneDB wants to merge 1 commit into
LocallyInsaneDB wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
build-windowsjob to.github/workflows/release.ymlso tagged releases automatically publish Windows installers alongside the existing macOS and Linux artifacts. No source changes —bundle.targets: "all"insrc-tauri/tauri.conf.jsonalready covers Windows targets; the job only needs to exist.What ships per release after this
Marky_<version>_x64-setup.exeMarky_<version>_x64.msiNaming follows the same
Marky_<version>_<arch>convention as the existing LinuxMarky_<version>_amd64.AppImageand macOSMarky_<version>_aarch64.tar.gzassets.Implementation
windows-latest— the GitHub-hosted image ships with MSVC 2022 Build Tools, the Windows SDK, and the WebView2 runtime, so no extra system-deps step is needed (unlike the Linux job).pnpm install→pnpm tauri build→ upload artifacts viagh release upload.shell: bash(Git Bash on the runner) so thefind/cp/if [ -n ... ]pattern matches the Linux job verbatim — easier to maintain.windows-11-arm) exist but are less stable; happy to add a matrix entry in a follow-up if you want it.Why now
The Marky README lists Homebrew (macOS) and
.deb(Ubuntu/Debian) install paths but no Windows entry. Forks/issues don't currently mention Windows, but the repo has a Tauri 2 setup that's a one-job addition away from full three-OS parity. I cross-compiled a working.exelocally viacargo-xwinfrom WSL to confirm the source tree is Windows-clean — this PR just adds the CI job to do the same thing the supported way on a native Windows runner.Test plan
v0.1.3-test1) on a branch and confirm both*-setup.exeand*.msiappear in the GitHub release alongside the existing macOS/Linux assets..exeon a clean Windows 10/11 VM; launch via Start menu; open a.mdfile via the file picker..msion the same VM (after uninstalling the NSIS build); confirm same behaviour.build-windowsjob at the bottom of the file).Happy to iterate on artifact naming, add arm64, switch to
tauri-apps/tauri-actionfor consistency with the macOS job, or anything else you'd prefer.