Clarify parameters of blockMobSpawns setting and list#324
Closed
LazyFlesh wants to merge 5 commits into
Closed
Conversation
LazyFlesh
added
Enhancement
LazyFlesh
changed the title
Author
|
revert attempt to swap to same event listener as mob repellator/mega torch/etc. as it's just not working. |
LazyFlesh
changed the title
Author
|
conflicts with #325, as it changed the way the spawn prevention works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I encountered confusion, both my own and others', on why mobs weren't spawning with certain settings of block mob spawns in claimed chunks with empty lists.
The code interprets an empty list as "block all mob types", which i assume is because the original coder assumed that if mob blocking is on and the ist is empty, that is what it should do, and will be interpreted as such by the players.
Further, it was assumed that the setting blocked normal mob spawns, not ALL, and so forced spawns would still work... but they don't. This doesn't work like mob repellator or chandelier/mega torch, it blocks all spawns, including forced, spawners, breeding mobs, etc.
This pr updates the Config comments to be clearer, so it's not left up to interpretation.
This closes GTNewHorizons/GT-New-Horizons-Modpack#25765 if merged. The spawn events to be blocked are more clearly defined, so confusion should be minimised.
Checklist