Add @gw2/markup-vue package#39
Open
darthmaim wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Vue integration package to the monorepo so Guild Wars 2® markup can be rendered as Vue VNodes/components, alongside the existing React and Solid implementations.
Changes:
- Introduces
@gw2/markup-vuepackage (component implementation, tests, docs, changelog, package metadata). - Updates top-level and related package documentation to reference the new Vue package.
- Updates
pnpm-lock.yamlto include the new workspace package and Vue/Vitest dependencies.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds @gw2/markup-vue to the package list. |
| pnpm-lock.yaml | Adds lock entries for the new packages/vue workspace and Vue-related dependencies. |
| packages/vue/vitest.config.ts | Adds Vitest configuration for the new Vue package tests. |
| packages/vue/test/vue.spec.ts | Adds SSR-based tests for the Vue component and slot customization. |
| packages/vue/src/vue.ts | Implements the Gw2Markup Vue component rendering parsed AST to VNodes. |
| packages/vue/README.md | Documents usage and slot customization for the Vue component. |
| packages/vue/package.json | Defines package exports/build/test scripts and dependencies/peerDependencies. |
| packages/vue/CHANGELOG.md | Adds initial changelog for the new package. |
| packages/to-jsx/README.md | Updates guidance to point users to React/Solid/Vue renderer packages when appropriate. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+27
to
+42
| - `#color` for color nodes (slot props: `color`, `children`) | ||
|
|
||
| ```vue | ||
| <template> | ||
| <Gw2Markup :markup="myMarkup"> | ||
| <template #br> | ||
| <br /> | ||
| </template> | ||
|
|
||
| <template #color="{ color, children }"> | ||
| <span :class="`color-${color.slice(1)}`"> | ||
| <component :is="children" /> | ||
| </span> | ||
| </template> | ||
| </Gw2Markup> | ||
| </template> |
Comment on lines
+27
to
+32
| h( | ||
| Gw2Markup, | ||
| { markup: 'before<c=@test>content<br><c=#bada55>color</c><br>after' }, | ||
| { | ||
| color: ({ color, children }: { color: string; children?: VNodeChild[] }) => | ||
| h('mark', { 'data-color': color }, children), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.