Add mnemonic string parsing, improve keystore/address handling, update README and tests#37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
MnemonicUtil.toMnemonicCodes(String)to trim, normalize whitespace, and split mnemonic sentences and update callers to use it (Identity,WalletManager,HDMnemonicKeystore,V3MnemonicKeystore).WalletManagerkeystore validation and address derivation by addingderiveAddressByChain,isBitcoinFamily, andisEvmFamilyhelpers and by passing chainType into keystore validation to enforce correct address checks for EVM families.String.split(" ")usages withMnemonicUtil.toMnemonicCodesand use normalized mnemonic lists when changing passwords or deriving wallets.README.mdto clarify features, supported chains, install instructions, quick-start runnable examples, security recommendations, and build/test commands.Testing
./gradlew testand./gradlew buildin CI (Java 8/11/17 matrix); the test run completed successfully.MnemonicUtilTest.toMnemonicCodes_string_shouldTrimAndNormalizeWhitespaceandMnemonicUtilTest.toMnemonicCodes_string_shouldRejectBlankInput, which passed.WalletManagerTest.findWalletByKeystore_ethereum_shouldReturnWalletandWalletManagerTest.findWalletByMnemonic_dogecoin_shouldReturnWallet, which passed.Codex Task