[Baylem]

Generated auxiliary containers had no consistent resource reservations, and management Deployments lacked a common placement/disruption configuration.

Add configurable requests for agents/config init, sentinels, tunnel relays and restic workers through operator flags and Helm. Explicit resource objects replace defaults, including an empty object to clear them. Add placement fields and optional PDBs for management Deployments, require leader election for multiple operator replicas, and document a management/game worker layout and upgrade behavior.

A scoped pre-upgrade hook clears server-defaulted rollingUpdate fields before applying Recreate to an existing operator with leader election disabled. It also works when CRDs are managed externally. The hook supports maximum-length Helm release names, and re-enabling leader election explicitly restores RollingUpdate.

Closes #724.

Validation:

• Operator production and ordinary/envtest/E2E test sources compile for Linux amd64.
• Added resource-precedence/parser regressions, chart render checks and a dedicated management-placement CI job covering scheduler constraints, spreading, eviction budgets and singleton API eviction.
• Actionlint and offline zizmor passed; independent review completed.
• Tests and chart/cluster checks were not executed locally, per repository policy.

Defaults are starting resource reservations, with no new CPU/memory limits; deployment measurements should guide tuning. Existing workloads may restart or become Pending as requests are applied. Keep the HostPort placement changes from #761 and the Cilium option from the network-isolation PR when resolving shared CI/controller files. API singleton lifecycle changes remain in #758. Web/Compose image builds on this base need #759.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: GameplanePanel/Gameplane
• Branch: master
• File: .coderabbit.yaml
• Commit: ca3a2ac
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: febef522-f313-44c4-9b6a-cefe4495c689

Commits

Reviewing files that changed from the base of the PR and between ca3a2ac and d9beb20.

Files selected for processing: 38

• .github/workflows/ci.yaml
• charts/gameplane/templates/NOTES.txt
• charts/gameplane/templates/_helpers.tpl
• charts/gameplane/templates/api.yaml
• charts/gameplane/templates/audit-syslog-bridge.yaml
• charts/gameplane/templates/crd-apply-hook.yaml
• charts/gameplane/templates/gateway.yaml
• charts/gameplane/templates/mcp-server.yaml
• charts/gameplane/templates/operator-strategy-migrate.yaml
• charts/gameplane/templates/operator.yaml
• charts/gameplane/templates/poddisruptionbudgets.yaml
• charts/gameplane/templates/telemetry-receiver.yaml
• charts/gameplane/templates/web.yaml
• charts/gameplane/values-production.example.yaml
• charts/gameplane/values.yaml
• charts/tests/check_workloads.py
• deploy/kind/e2e.sh
• docs/production-placement.md
• docs/release-notes.md
• hack/ci_scope.py
• hack/test_ci_scope.py
• operator/cmd/main.go
• operator/internal/controller/auxiliary_resources.go
• operator/internal/controller/auxiliary_resources_test.go
• operator/internal/controller/backup_controller.go
• operator/internal/controller/backup_forget.go
• operator/internal/controller/gameserver_controller.go
• operator/internal/controller/gameserver_sentinel.go
• operator/internal/controller/gameserver_tunnel.go
• operator/internal/controller/restore_controller.go
• operator/specs.md
• test/e2e/api_events_roles_scope_e2e_test.go
• test/e2e/buckets.sh
• test/e2e/ci_selection_e2e_test.go
• test/e2e/management_placement_e2e_test.go
• test/e2e/specs.md
• test/e2e/suite-components.json
• test/e2e/upgrade_e2e_test.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ValgulNecron]

Hey, thanks for this one. I'm fine with the new default resource requests, and with game pods rolling once on upgrade.

One thing I don't want: charts/gameplane/templates/validate.yaml:1-2 now makes helm upgrade fail when operator.replicas > 1 and leaderElect=false. Anyone already running that combination (especially with --reuse-values) gets a broken upgrade with no warning. I'd rather upgrades never hard-fail on a setting that used to work.

Could you change it so the chart handles it instead? For example, turn leader election on automatically when replicas > 1, or keep rendering and print a clear warning in NOTES.txt. Please also update the release notes and the chart check to match.

While you're there, it would make review easier if the operator Recreate migration Job and the PDBs went into their own PR, since they're not really part of "auxiliary resources and placement".

Thanks!

[Baylem]

Addressed in 6d8d42c.

Removed the upgrade failure. When operator.replicas is greater than one, the chart now enables leader election automatically and renders RollingUpdate even if saved values contain leaderElect: false. NOTES.txt explains the effective setting, the singleton Recreate migration hook is skipped for that case, and the release notes plus chart checks cover old values and --reuse-values.

I retained the optional PDBs and singleton migration hook in this revision. #724 explicitly requested the PDBs with placement; the hook is coupled to the retained Recreate strategy because Helm server-side apply cannot clear the old defaulted RollingUpdate fields by itself. Moving the hook without that strategy change would break the singleton upgrade path. This keeps those dependencies intact without rewriting the shared PR stack.

The chart check source compiles; Helm/runtime regression execution remains in CI.