Skip to content

ci: add move parity checks (spec 028) - #796

Merged
ValgulNecron merged 5 commits into
masterfrom
claude/project-thread-i21t8f
Oct 25, 2026
Merged

ValgulNecron merged 5 commits into
masterfrom
claude/project-thread-i21t8f

Conversation

@ValgulNecron

@ValgulNecron ValgulNecron commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

First PR of spec 028 (split big packages and files): the tooling every move PR relies on, plus the Phase 1 bookkeeping.

Changes

  • hack/move_parity.py (Python stdlib, T004)
    • names <base> <head>: static scan of Go Test/Fuzz/Example/Benchmark funcs (keyed by module, package path dropped, TestMain skipped) and Vitest/Playwright title chains; the two multisets must be equal.
    • test-edits <base> <head> --brief <file>: pairs changed test files (git renames, the brief's Moves table, New files copies) and fails on any difference beyond the OD-6/OD-9 kinds (package line, imports, qualified names from the Exports table, vi.mock/import() path strings, one extra ".." per folder level in a copied envtest setup).
    • ci --base --head: runs both for each brief the change adds or edits; skips when there is none.
  • hack/test_move_parity.py (T005): the cases from tasks.md, run by make test-ci-scope.
  • CI (T006): new PR-only move parity (spec 028) job; the two files join the github paths filter so workflow lint runs their unit tests. They do not force the full suite.
  • specs/028-split-big-packages/briefs/README.md (T007).
  • Spec bookkeeping: T002/T003 re-measure on 54d5819 recorded in research.md (spec 027's docs/layout.md merged via docs: spec 027 contributor docs and layout map #795, so briefs cite it); OD-11 settled (split web/scripts/i18n-migrate.ts, new task T061).

Checks

Locally only py_compile and a move_parity.py names origin/master HEAD smoke run after merging master (equal, 7451 tests). Unit tests run in CI (CLAUDE.md rule 8): workflow lint and move parity (spec 028) green, full run 33/33 passed.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
hack/move_parity.py proves a move PR keeps every test name (names) and
changes test files only in the OD-6/OD-9 mechanical ways (test-edits).
The move-parity job runs it on any PR that adds a brief under
specs/028-split-big-packages/briefs/; the unit tests run in make
test-ci-scope.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@ValgulNecron ValgulNecron added type: ci CI, workflows, or build tooling area: shared netguard, gameaction, gameproto, svcutil and other shared packages labels Oct 22, 2026 — with Claude
@ValgulNecron ValgulNecron self-assigned this Oct 22, 2026
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 446d903 and c23b2f2.

Files selected for processing: 9
  • .github/workflows/ci.yaml
  • Makefile
  • hack/move_parity.py
  • hack/test_move_parity.py
  • specs/028-split-big-packages/OPEN-DECISIONS.md
  • specs/028-split-big-packages/briefs/README.md
  • specs/028-split-big-packages/research.md
  • specs/028-split-big-packages/spec.md
  • specs/028-split-big-packages/tasks.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

CI Report - c23b2f2

run 40233118127 - attempt 2

0 failed - 33 passed - 0 skipped - unknown elapsed

Test selection: full (selection-rule change) - per-suite table

Coverage

Module Measured Gate Margin
web L95.87 S94.37 B89.27 F91.79 L92 S92 B82 F76 +2.37

Changed

Area Files +/-
hack/ 2 +699/-0
specs/ 5 +35/-8
.github/ 1 +24/-0
(root) 1 +1/-0

Slowest jobs

no job duration data available

e2e buckets run

bot-fast

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>

Copy link
Copy Markdown
Collaborator Author

build e2e images (amd64) on c23b2f2 hit its 15-minute timeout (job ran 15m23s; the image build step itself took 14m48s with no failing step), which skipped the amd64 e2e jobs. This PR changes no Dockerfile or image input (only hack/, specs/, one new CI job and a Makefile test line), and the same job finished in 10m47s on the previous head f2e025c. Re-ran the failed jobs once.


Generated by Claude Code

@ValgulNecron
ValgulNecron merged commit f5a8fe8 into master Oct 25, 2026
193 of 194 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: shared netguard, gameaction, gameproto, svcutil and other shared packages type: ci CI, workflows, or build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants