Feature/handle response#16
Merged
Merged
Conversation
Plugin methods can now yield/return Result, List[Result], or use generators without calling send_results() explicitly. Introduces types.py to break the result.py→plugin.py circular import, and response.py with handle_response() applied transparently in the on_method wrapper. Async generators are handled in EventHandler.
- Extract _collect_item helper to deduplicate Result/list collection in both sync generators and async generators - Fix _await_maybe to handle async functions returning Result or list by routing through handle_response-equivalent logic - Move handle_response wrapping into add_method so on_method returns the original unwrapped function (preserving _is_registered_method on it) - Filter non-Result items from list branches consistently - Update tests to check event registration by key presence and add regression tests for async return, flag preservation, and list filtering
…n favour of feature branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.