Skip to content

Align campus credential mock and settings UI#46

Merged
Pigbibi merged 1 commit into
masterfrom
codex/campus-credential-settings-ui
Apr 28, 2026
Merged

Align campus credential mock and settings UI#46
Pigbibi merged 1 commit into
masterfrom
codex/campus-credential-settings-ui

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • reset Android mock campus credential state during mock login
  • align campus credential settings with status summary, quick auth switch, and danger section
  • add smoke coverage for credential status/actions and relogin behavior

Verification

  • ./gradlew --no-daemon --max-workers=1 -Dorg.gradle.jvmargs=-Xmx768m :app:testDebugUnitTest --tests cn.gdeiassistant.network.MockInterceptorSmokeTest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab207a5632

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

hasSavedCredential = false,
quickAuthAllowed = false,
consentedAt = null,
campusAccount = MockUtils.MOCK_STUDENT_NUMBER

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear account field when login declines credential consent

In resetForLogin, the hasConsent == false branch sets hasSavedCredential = false but still stores campusAccount, and toPayload() always returns maskedCampusAccount from that value. This yields an inconsistent status payload (hasSavedCredential: false while account is still present), so the settings UI/API consumers can incorrectly treat a credential as still on file after a no-consent login. Align this branch with revoke/delete behavior by clearing the account when no credential is saved.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi force-pushed the codex/campus-credential-settings-ui branch from ab207a5 to 029cd23 Compare April 28, 2026 18:37
@Pigbibi Pigbibi merged commit a4b2034 into master Apr 28, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/campus-credential-settings-ui branch April 28, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant