Align campus credential mock and settings UI#46
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab207a5632
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| hasSavedCredential = false, | ||
| quickAuthAllowed = false, | ||
| consentedAt = null, | ||
| campusAccount = MockUtils.MOCK_STUDENT_NUMBER |
There was a problem hiding this comment.
Clear account field when login declines credential consent
In resetForLogin, the hasConsent == false branch sets hasSavedCredential = false but still stores campusAccount, and toPayload() always returns maskedCampusAccount from that value. This yields an inconsistent status payload (hasSavedCredential: false while account is still present), so the settings UI/API consumers can incorrectly treat a credential as still on file after a no-consent login. Align this branch with revoke/delete behavior by clearing the account when no credential is saved.
Useful? React with 👍 / 👎.
ab207a5 to
029cd23
Compare
Summary
Verification