Skip to content

Harden release demo controls and language labels#50

Merged
Pigbibi merged 2 commits into
masterfrom
codex/release-demo-i18n-20260611
Jun 10, 2026
Merged

Harden release demo controls and language labels#50
Pigbibi merged 2 commits into
masterfrom
codex/release-demo-i18n-20260611

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • force release builds away from mock/demo data and non-prod environments
  • hide demo/network controls when runtime debug options are unavailable
  • localize the top bar back action and remove negative letter spacing
  • share language option labels and rename zh-HK to Hong Kong/Macau

Verification

  • git diff --check
  • static search for negative letter spacing and hard-coded Back content description

Note: Android unit tests could not run here because ANDROID_HOME / Android SDK is not configured.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc25f2d78e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Icon(
imageVector = Icons.AutoMirrored.Filled.ArrowBack,
contentDescription = "Back",
contentDescription = stringResource(R.string.back),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the imports for the localized back label

Changing the literal to stringResource(R.string.back) leaves this file without either androidx.compose.ui.res.stringResource or cn.gdeiassistant.R in its imports, so any build that compiles AppTopBar fails with unresolved references instead of producing the localized content description.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 114dc2b into master Jun 10, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/release-demo-i18n-20260611 branch June 10, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant