Harden release demo controls and language labels#50
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc25f2d78e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Icon( | ||
| imageVector = Icons.AutoMirrored.Filled.ArrowBack, | ||
| contentDescription = "Back", | ||
| contentDescription = stringResource(R.string.back), |
There was a problem hiding this comment.
Add the imports for the localized back label
Changing the literal to stringResource(R.string.back) leaves this file without either androidx.compose.ui.res.stringResource or cn.gdeiassistant.R in its imports, so any build that compiles AppTopBar fails with unresolved references instead of producing the localized content description.
Useful? React with 👍 / 👎.
Summary
Verification
Note: Android unit tests could not run here because ANDROID_HOME / Android SDK is not configured.