Skip to content

Add Android release workflow#52

Merged
Pigbibi merged 1 commit into
masterfrom
codex/android-release-workflow-20260611
Jun 10, 2026
Merged

Add Android release workflow#52
Pigbibi merged 1 commit into
masterfrom
codex/android-release-workflow-20260611

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a manual Android release workflow that builds signed APK and AAB artifacts and creates a GitHub Release.
  • Add Gradle properties for release signing and version overrides.
  • Document release credentials and local signed build usage in the README.

Validation

  • YAML parsed with Node yaml
  • git diff --check
  • ./gradlew :app:help --no-daemon --max-workers=1 -Dorg.gradle.jvmargs=-Xmx512m

Notes

A local :app:testDebugUnitTest run was attempted with --no-daemon --max-workers=1 -Dorg.gradle.jvmargs=-Xmx768m, but it hit the 12 minute VPS timeout while compiling Kotlin on this 2GB RAM machine. The PR CI should run the full Android checks on GitHub Actions.

The release workflow requires ANDROID_KEYSTORE_BASE64, ANDROID_KEYSTORE_PASSWORD, ANDROID_KEY_ALIAS, and ANDROID_KEY_PASSWORD before it can publish signed release artifacts.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31df2882e8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +93 to +94
-PGDEI_VERSION_NAME="${{ inputs.version_name }}" \
-PGDEI_VERSION_CODE="${{ inputs.version_code }}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pass workflow inputs through env before shell use

Because these workflow_dispatch inputs are interpolated directly into the shell script while the signing secrets are present in the environment, a dispatcher can supply a value containing a double quote and shell metacharacters (for example in version_name) to break out of the quoted -P... argument and run arbitrary commands that can read the keystore passwords or use the write-scoped GITHUB_TOKEN. Put the inputs into step env values and reference those shell variables instead of embedding ${{ inputs.* }} in run.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 876b058 into master Jun 10, 2026
3 checks passed
@Pigbibi Pigbibi deleted the codex/android-release-workflow-20260611 branch June 10, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant