Harden debug data source controls and localization#44
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 943046a1b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _ environment: NetworkEnvironment, | ||
| isDebug: Bool | ||
| ) -> NetworkEnvironment { | ||
| allowsRuntimeDebugOptions(isDebug: isDebug) ? environment : .prod |
There was a problem hiding this comment.
In a build/config that sets GDEIDefaultNetworkEnvironment=staging with runtime debug options disabled (for example Configs/Staging.xcconfig sets staging and GDEI_ALLOW_RUNTIME_DEBUG_OPTIONS = NO), AppRouter passes that selected environment into AppEnvironment, but this ternary replaces every disallowed-debug environment with .prod. That makes staging builds call production APIs instead of the configured staging base URL; mock data should be forced off without discarding the build-selected network environment.
Useful? React with 👍 / 👎.
| return "简体中文" | ||
| case .traditionalChineseHongKong: | ||
| return "繁體中文（香港）" | ||
| return "繁體中文（港澳）" |
There was a problem hiding this comment.
With this option now labelled 港澳, Macau locales still won't select it: language(from:) only maps zh-HK to this case, while zh-Hant-MO is routed by the generic hant branch to Taiwan and zh-MO falls through to simplified Chinese. A device whose preferred language is Macau Traditional Chinese therefore won't get the Hong Kong/Macau localization automatically, so the Macau identifiers need to be added to this branch when broadening the label.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
Note: xcodebuild and plutil are unavailable in this Linux environment.