Skip to content

Map Macau Traditional Chinese to Hong Kong locale#47

Merged
Pigbibi merged 1 commit into
mainfrom
codex/ios-macau-traditional-locale
Jun 11, 2026
Merged

Map Macau Traditional Chinese to Hong Kong locale#47
Pigbibi merged 1 commit into
mainfrom
codex/ios-macau-traditional-locale

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • map Macau Traditional Chinese locale identifiers to the zh-HK option
  • keep the Traditional Chinese language picker aligned as one Hong Kong/Macau option and one Taiwan option
  • add coverage for zh-Hant-MO and zh-MO normalization

Validation

  • git diff --check
  • iOS unit tests not run locally because this Linux VPS does not provide xcodebuild

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e5dcac166

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +100 to 101
if segments.contains("hk") || segments.contains("mo") {
return .traditionalChineseHongKong

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve explicit Hans in Macau locales

When iOS supplies a script-qualified simplified Macau locale such as zh-Hans-MO, this new segments.contains("mo") check runs before the existing script check, so normalizedIdentifier(from:) now returns zh-HK and the app loads Traditional Chinese despite the identifier explicitly requesting Hans. The change is intended for Macau Traditional Chinese, but this branch also captures Simplified Chinese Macau variants; handle hans before the Macau region fallback or special-case zh-Hans-MO as simplified.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 43fb6f9 into main Jun 11, 2026
5 checks passed
@Pigbibi Pigbibi deleted the codex/ios-macau-traditional-locale branch June 11, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant