Map Macau Traditional Chinese to Hong Kong locale#47
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e5dcac166
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if segments.contains("hk") || segments.contains("mo") { | ||
| return .traditionalChineseHongKong |
There was a problem hiding this comment.
Preserve explicit Hans in Macau locales
When iOS supplies a script-qualified simplified Macau locale such as zh-Hans-MO, this new segments.contains("mo") check runs before the existing script check, so normalizedIdentifier(from:) now returns zh-HK and the app loads Traditional Chinese despite the identifier explicitly requesting Hans. The change is intended for Macau Traditional Chinese, but this branch also captures Simplified Chinese Macau variants; handle hans before the Macau region fallback or special-case zh-Hans-MO as simplified.
Useful? React with 👍 / 👎.
Summary
Validation