[codex] Apply UI review optimizations#48
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e01d9ba1a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| publishViewModel: container.makePublishMarketplaceViewModel() | ||
| ) | ||
| } | ||
| .accessibilityIdentifier("marketplace.publishEntry") |
There was a problem hiding this comment.
Keep the publish entry discoverable for UI tests
When the marketplace toolbar is collapsed into this Menu, the marketplace.publishEntry accessibility identifier is now attached to a menu item that is not present in the accessibility tree until the menu is opened. The existing smoke test still waits for and taps app.buttons["marketplace.publishEntry"] directly in GdeiAssistant-iOSUITests/MockUISmokeTests.swift lines 33-45, so this flow will time out before it can open the publish screen unless the test is updated to open the More menu first or a compatible toolbar control remains exposed.
Useful? React with 👍 / 👎.
Summary
Validation
Note: xcodebuild is unavailable on this Linux VPS, so native iOS build verification should run on macOS.