Skip to content

[codex] Apply UI review optimizations#48

Merged
Pigbibi merged 2 commits into
mainfrom
codex/ui-review-optimizations
Jun 11, 2026
Merged

[codex] Apply UI review optimizations#48
Pigbibi merged 2 commits into
mainfrom
codex/ui-review-optimizations

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Convert fixed-height design-system controls to min-height layouts
  • Add a full schedule list and reduce content image cropping
  • Move community top-bar text actions into a More menu and add localized labels

Validation

  • Static scan for fixed-height controls, top-bar action groups, image scaling, and added localization keys
  • Localizable.strings duplicate-key and basic format checks
  • git diff --check

Note: xcodebuild is unavailable on this Linux VPS, so native iOS build verification should run on macOS.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e01d9ba1a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

publishViewModel: container.makePublishMarketplaceViewModel()
)
}
.accessibilityIdentifier("marketplace.publishEntry")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the publish entry discoverable for UI tests

When the marketplace toolbar is collapsed into this Menu, the marketplace.publishEntry accessibility identifier is now attached to a menu item that is not present in the accessibility tree until the menu is opened. The existing smoke test still waits for and taps app.buttons["marketplace.publishEntry"] directly in GdeiAssistant-iOSUITests/MockUISmokeTests.swift lines 33-45, so this flow will time out before it can open the publish screen unless the test is updated to open the More menu first or a compatible toolbar control remains exposed.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 783038e into main Jun 11, 2026
4 checks passed
@Pigbibi Pigbibi deleted the codex/ui-review-optimizations branch June 11, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant