[codex] Stabilize primary brand color and style checks#49
Merged
Conversation
Pigbibi
commented
Jun 11, 2026
Pigbibi
left a comment
Pigbibi
left a comment
Contributor
Author
There was a problem hiding this comment.
Codex review complete.
Checked the PR scope against the design-system/tooling review goals: DSColor.primary now uses explicit Campus Green values, and Tools/check_style.sh keeps git behavior while adding a non-git fallback. No blocking issues found. CI is expected to remain the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DSColor.primaryas explicit Campus Green values instead of depending onColor.accentColor.git ls-filesbehavior in git worktrees, but fall back tofind . -name '*.swift'when runningTools/check_style.shfrom a source zip or artifact directory.Validation
./Tools/check_style.sh— passedswiftc -parse -sdk "$(xcrun --sdk macosx --show-sdk-path)" GdeiAssistant-iOS/Core/DesignSystem/DSColor.swift— passed./Tools/build_simulator.sh— passed,** BUILD SUCCEEDED **with Xcode 26.3git diff --checkLogs:
/Users/lisiyi/Projects/GdeiAssistantReview/artifacts/landing/ios/check-style-after-xcode.log/Users/lisiyi/Projects/GdeiAssistantReview/artifacts/landing/ios/dscolor-swift-parse-after-xcode.log/Users/lisiyi/Projects/GdeiAssistantReview/artifacts/landing/ios/build-simulator-after-xcode.log/Users/lisiyi/Projects/GdeiAssistantReview/artifacts/landing/ios/git-diff-check-after-xcode.log/Users/lisiyi/Projects/GdeiAssistantReview/artifacts/landing/git-diff-check.logNotes / Risks
DSColor.primary.Codex review request
Please run/consider Codex review for UI/layout/architecture regressions before merge. This PR was prepared from the multi-repo UI architecture review and is intentionally limited to low-risk scope.