Skip to content

ci(release): don't use secrets in a step if: (startup failure)#92

Merged
GeiserX merged 1 commit into
mainfrom
fix/release-workflow-secrets-if
Jul 11, 2026
Merged

ci(release): don't use secrets in a step if: (startup failure)#92
GeiserX merged 1 commit into
mainfrom
fix/release-workflow-secrets-if

Conversation

@GeiserX

@GeiserX GeiserX commented Jul 11, 2026

Copy link
Copy Markdown
Owner

The desktop release workflow failed at startup on every tag — the Sign Windows binaries step gated on secrets.WINDOWS_SIGN_CERT != in its if:, but the secrets context is not allowed in if: expressions, so GitHub rejected the whole workflow (a "workflow file issue" run with no jobs). No desktop release has actually built since that step was added.

Fix: gate the step on runner.os == 'Windows' only, and check the secret inside the run body (skip signing when unset). Unblocks tagged releases. Discovered while releasing v0.10.0 (per-worker fleet keys).

The Windows signing step gated on secrets.WINDOWS_SIGN_CERT in its if:, but the
secrets context is not allowed in if: expressions — GitHub rejected the whole
desktop-release workflow at startup, so no release built since it was added. Gate
on runner.os only and check the secret inside the run body (skips signing when
unset). Unblocks tagged desktop releases.
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@GeiserX, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a1026e3c-8f66-42ed-9308-ebd2ef9a799a

📥 Commits

Reviewing files that changed from the base of the PR and between dfd2699 and 614dca4.

📒 Files selected for processing (1)
  • .github/workflows/desktop-release.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-workflow-secrets-if

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.92%. Comparing base (dfd2699) to head (614dca4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   74.92%   74.92%           
=======================================
  Files          14       14           
  Lines        3418     3418           
=======================================
  Hits         2561     2561           
  Misses        669      669           
  Partials      188      188           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GeiserX GeiserX merged commit 01db338 into main Jul 11, 2026
6 checks passed
@GeiserX GeiserX deleted the fix/release-workflow-secrets-if branch July 11, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant