ci(release): don't use secrets in a step if: (startup failure)#92
Conversation
The Windows signing step gated on secrets.WINDOWS_SIGN_CERT in its if:, but the secrets context is not allowed in if: expressions — GitHub rejected the whole desktop-release workflow at startup, so no release built since it was added. Gate on runner.os only and check the secret inside the run body (skips signing when unset). Unblocks tagged desktop releases.
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage 74.92% 74.92%
=======================================
Files 14 14
Lines 3418 3418
=======================================
Hits 2561 2561
Misses 669 669
Partials 188 188 🚀 New features to boost your workflow:
|
The desktop release workflow failed at startup on every tag — the
Sign Windows binariesstep gated onsecrets.WINDOWS_SIGN_CERT !=in itsif:, but thesecretscontext is not allowed inif:expressions, so GitHub rejected the whole workflow (a "workflow file issue" run with no jobs). No desktop release has actually built since that step was added.Fix: gate the step on
runner.os == 'Windows'only, and check the secret inside therunbody (skip signing when unset). Unblocks tagged releases. Discovered while releasing v0.10.0 (per-worker fleet keys).