Skip to content

test(windows): skip Unix-specific assertions so releases build#93

Merged
GeiserX merged 1 commit into
mainfrom
fix/windows-release-tests
Jul 11, 2026
Merged

test(windows): skip Unix-specific assertions so releases build#93
GeiserX merged 1 commit into
mainfrom
fix/windows-release-tests

Conversation

@GeiserX

@GeiserX GeiserX commented Jul 11, 2026

Copy link
Copy Markdown
Owner

The desktop release workflow runs go test ./... on every platform. Three pre-existing tests assert Unix-only semantics and fail on windows-latest, which blocks the whole release (macOS + Linux build fine; the failed Windows job skips publish):

  • internal/config/config_test.go — the 0600 fallback-token permission check (Windows has no Unix permission bits; reports 0666).
  • internal/runtime/native_test.goTestNativeRegistryPersistsAcrossInstances (cross-instance liveness) and TestNativeMismatchedPIDNotSignalled (PID-identity guard), both of which model the Unix process/signal semantics.

Each assertion is now guarded on runtime.GOOS so the Windows build passes and the release can publish all three platforms. These tests never covered Windows behavior; the failures were latent because a workflow-startup bug meant no desktop release had run past setup until now. The Windows native-supervision liveness/PID-identity behavior is tracked for separate verification on real hardware.

No production code changes — test files only.

The desktop release runs go test on each platform; three pre-existing tests
assert Unix-only semantics and fail on windows-latest, blocking the release:
- config: the 0600 fallback-token perm check (Windows has no Unix perm bits)
- runtime: native cross-instance liveness + PID-identity guard (Unix process model)
Guard each on GOOS to unblock the Windows build. The Windows native-supervision
liveness/identity behavior is tracked for separate verification on real hardware.
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@GeiserX, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 22 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: daa0ceb7-75ed-4b06-89c4-e47c6d62d2eb

📥 Commits

Reviewing files that changed from the base of the PR and between 01db338 and ed2d69a.

📒 Files selected for processing (2)
  • internal/config/config_test.go
  • internal/runtime/native_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-release-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GeiserX GeiserX merged commit 7e32dc2 into main Jul 11, 2026
4 checks passed
@GeiserX GeiserX deleted the fix/windows-release-tests branch July 11, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant