test(windows): skip Unix-specific assertions so releases build#93
Conversation
The desktop release runs go test on each platform; three pre-existing tests assert Unix-only semantics and fail on windows-latest, blocking the release: - config: the 0600 fallback-token perm check (Windows has no Unix perm bits) - runtime: native cross-instance liveness + PID-identity guard (Unix process model) Guard each on GOOS to unblock the Windows build. The Windows native-supervision liveness/identity behavior is tracked for separate verification on real hardware.
|
Warning Review limit reached
Next review available in: 22 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The desktop release workflow runs
go test ./...on every platform. Three pre-existing tests assert Unix-only semantics and fail onwindows-latest, which blocks the whole release (macOS + Linux build fine; the failed Windows job skipspublish):internal/config/config_test.go— the0600fallback-token permission check (Windows has no Unix permission bits; reports0666).internal/runtime/native_test.go—TestNativeRegistryPersistsAcrossInstances(cross-instance liveness) andTestNativeMismatchedPIDNotSignalled(PID-identity guard), both of which model the Unix process/signal semantics.Each assertion is now guarded on
runtime.GOOSso the Windows build passes and the release can publish all three platforms. These tests never covered Windows behavior; the failures were latent because a workflow-startup bug meant no desktop release had run past setup until now. The Windows native-supervision liveness/PID-identity behavior is tracked for separate verification on real hardware.No production code changes — test files only.