[COTLMP] Improve the Server class#26
Merged
Merged
Conversation
… folder Player is a data class, so move it to its appropriate place.
Since the util methods can be used outside of the messages scope, just move it to the main directory of the server.
Fields like game mode and server name weren't taken into account so one had no idea what kind of server it was apart from its assigned port. The newly added arguments are necessary to have a full detail info of the server as one browses the servers list...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a split from #25 as requested.
Proposed changes
Serverclass