fix(ui): make video fit adaptive on web and desktop#1271
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe ChangesNullable videoFit resolution
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant Widget as VideoTrackRenderer
participant Renderer as _videoRenderer
participant Builder as ValueListenableBuilder
participant FitResolver as _getVideoViewObjectFit
Widget->>Renderer: initialize
Renderer-->>Widget: RTCVideoValue update
Widget->>Builder: rebuild with value
Builder->>FitResolver: resolve(videoFit, value)
FitResolver-->>Builder: objectFit (cover/contain)
Builder-->>Widget: render video view
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1271 +/- ##
=======================================
Coverage 10.16% 10.16%
=======================================
Files 679 679
Lines 49765 49773 +8
=======================================
+ Hits 5059 5060 +1
- Misses 44706 44713 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
New Features
Bug Fixes