fix(server): increment total_downloads on pack download#12
Merged
Conversation
The catalog `total_downloads` counter shown on the marketplace was never
incremented by any route: the download handler only recorded a `pack_downloads`
event (which feeds the 7-day Trending ranking), while the counter that backs
`total_downloads` is bumped exclusively by `increment_download_counter`, which
no handler called. As a result every pack reported 0 total downloads.
Wire `increment_download_counter` into `download_pack_bytes` alongside the
existing `record_download` call, as a best-effort step that warns and continues
on failure so a download the client already received is never failed. Document
why the signed `/dl/{hash}` path cannot increment the counter (it has only the
content hash, not name/version; the official client uses the direct route).
Add an integration test asserting a successful download increments the counter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every pack on the marketplace reports
total_downloads: 0. Root cause: the counter that backstotal_downloadsis only bumped byCatalogBackend::increment_download_counter, and no route ever called it. The download handler calledrecord_download(which only inserts apack_downloadsrow feeding the 7-day Trending window), so the cumulative counter never moved.Fix
download_pack_bytesnow callsincrement_download_counteralongsiderecord_download, best-effort (warn and continue on error, never fail a delivered download)./dl/{hash}path can't increment it (only has the content hash; the official client uses the direct/packroute).Verification
cargo build -p frameshift-serverandcargo test -p frameshift-serverpass (73 tests incl. the newdownload_pack_increments_download_counter). Postgres-backed integration tests were not run (require a live DB); the new test uses the mock catalog.Base is
feat/land-m3because the touched files diverge frommainon that branch.