fix(seed): store packs as gzip-tar so registry installs succeed#27
Merged
Conversation
The seeder wrote each pack to the object store as the raw canonical byte stream, but the client install path decompresses the blob with extract_targz, so every registry install failed with "invalid gzip header". Package the persona directory into a gzipped tar (new targz_dir, matching the publish path) and content-address the archive bytes; the pack signature still covers the canonical hash, which is now decoupled from the stored content hash. Remove the now-dead pack_canonical_bytes/collect_entries_for_bytes and the unicode-normalization dependency, add tar and flate2, and add a regression test asserting the object-store payload is gzip with pack.toml at the archive root and signature.sig excluded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The seeder stored each pack in the object store as the raw canonical byte
stream, but the client install path (
extract_targz) decompresses the blobas gzip-tar. Every registry install of a seeded pack therefore failed with
invalid gzip header.Fix
targz_dir, matchingthe publish path format) and content-address the archive bytes.
is now correctly decoupled from it.
pack_canonical_bytes/collect_entries_for_bytesandthe
unicode-normalizationdependency; addtarandflate2.pack.tomlat the archive root andsignature.sigexcluded.Verification
cargo clippy -p frameshift-seed --all-targets -- -D warnings: cleancargo test -p frameshift-seed: 10/10 pass@0.1.0packs) already remediatedout of band; all now install end-to-end through the client.