Update VM requirements for supported Linux versions#2877
Conversation
Signed-off-by: manoj suryawanshi <manojsurya78@gmail.com>
|
Warning Review limit reached
More reviews will be available in 52 minutes and 12 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated VM installation docs and requirements: the supported distro matrix now lists newer Ubuntu, SUSE, and RHEL versions; RHEL guide references EL9 artifacts and simplified mod_auth_openidc install; SUSE guide references SUSE 16 artifacts and updated verification/install commands. ChangesSupported Linux Distro Version Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mo-auto
added
the
area-documentation
Signed-off-by: manoj suryawanshi <manojsurya78@gmail.com>
Signed-off-by: manoj suryawanshi <manojsurya78@gmail.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
docs/install/vm-install/suse.md (1)
59-59:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winIncorrect version placeholder and bundle filename in download URL.
The bundle download command has two issues:
- The URL path uses
vreplace-janssen-versionbut should usevreplace-flex-version(consistent with the RHEL guide at line 59 and Ubuntu guide examples)- The bundle filename to download should be
flex-suse16-replace-flex-version-stable.bundleto match the filename referenced in the cosign verification command at Line 66This will cause the download and subsequent verification to fail.
🐛 Proposed fix
- wget https://github.com/GluuFederation/flex/releases/download/vreplace-janssen-version/flex_replace-flex-version-stable.bundle -P /tmp + wget https://github.com/GluuFederation/flex/releases/download/vreplace-flex-version/flex-suse16-replace-flex-version-stable.bundle -P /tmp🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/install/vm-install/suse.md` at line 59, Update the wget command URL and filename in the docs: change the path segment "vreplace-janssen-version" to "vreplace-flex-version" and replace the bundle filename "flex_replace-flex-version-stable.bundle" with "flex-suse16-replace-flex-version-stable.bundle" so the downloaded file matches the cosign verification step; edit the wget line in docs/install/vm-install/suse.md accordingly.docs/install/vm-install/rhel.md (1)
92-92:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winInconsistent RPM filename - references EL8 instead of EL9.
The install command references
el8.x86_64.rpmbut the entire guide was updated to use EL9 artifacts. The download command at Line 43 downloads the EL9 RPM, and the verification at lines 66-69 verifies the EL9 RPM. This inconsistency will cause the installation to fail with a "file not found" error.🐛 Proposed fix
-sudo yum install ./flex-replace-flex-version-stable.el8.x86_64.rpm +sudo yum install ./flex-replace-flex-version-stable.el9.x86_64.rpm🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/install/vm-install/rhel.md` at line 92, Replace the incorrect RPM filename "flex-replace-flex-version-stable.el8.x86_64.rpm" used in the install command with the EL9 artifact name "flex-replace-flex-version-stable.el9.x86_64.rpm" so the install step matches the earlier download and verification steps; update any other occurrences of the el8 filename in this document to the el9 filename to keep the guide consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/install/vm-install/vm-requirements.md`:
- Line 13: Change the product name spelling in the docs entry that currently
reads "RedHat Enterprise Linux (version: 9 and 10)" to use the correct two-word
form "Red Hat Enterprise Linux (version: 9 and 10)"; update that exact string in
the vm-requirements.md content so the documentation consistently uses "Red Hat"
instead of "RedHat".
---
Outside diff comments:
In `@docs/install/vm-install/rhel.md`:
- Line 92: Replace the incorrect RPM filename
"flex-replace-flex-version-stable.el8.x86_64.rpm" used in the install command
with the EL9 artifact name "flex-replace-flex-version-stable.el9.x86_64.rpm" so
the install step matches the earlier download and verification steps; update any
other occurrences of the el8 filename in this document to the el9 filename to
keep the guide consistent.
In `@docs/install/vm-install/suse.md`:
- Line 59: Update the wget command URL and filename in the docs: change the path
segment "vreplace-janssen-version" to "vreplace-flex-version" and replace the
bundle filename "flex_replace-flex-version-stable.bundle" with
"flex-suse16-replace-flex-version-stable.bundle" so the downloaded file matches
the cosign verification step; edit the wget line in
docs/install/vm-install/suse.md accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8acb1083-bbcd-4eb3-a7ef-7c2cdec9971b
📒 Files selected for processing (3)
docs/install/vm-install/rhel.mddocs/install/vm-install/suse.mddocs/install/vm-install/vm-requirements.md
Signed-off-by: manoj suryawanshi <manojsurya78@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/install/vm-install/vm-requirements.md`:
- Line 13: The VM requirements line "Red Hat Enterprise Linux (version: 9 and
10)" is misleading because EL10 content is missing; either expand the VM install
docs to explicitly include EL10 entries (add EL10 package/bundle names, download
URLs, RPM bundle verification steps, and any EL10-specific prerequisites) or
change that phrase to only mention EL9. Locate the exact string "Red Hat
Enterprise Linux (version: 9 and 10)" in vm-requirements.md and update the
surrounding sections: if adding EL10, mirror the EL9 package/bundle names and
verification commands for EL10 (including automation/packaging/rpm/el10/
artifact names and expected checksums/signatures), or if removing EL10, change
the text to "Red Hat Enterprise Linux (version: 9)" and remove any EL10
references elsewhere in the document.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: e6b6ac24-2ede-4e8a-8a47-87800c034ea7
📒 Files selected for processing (1)
docs/install/vm-install/vm-requirements.md
Signed-off-by: manoj suryawanshi <manojsurya78@gmail.com>
3 participants
Summary by CodeRabbit