Skip to content

fix(flex-linux-setup): fetch admin-ui-plugin from the jans GitHub release#2886

Merged
moabu merged 1 commit into
mainfrom
fix/admin-ui-plugin-release-url
Jun 23, 2026
Merged

fix(flex-linux-setup): fetch admin-ui-plugin from the jans GitHub release#2886
moabu merged 1 commit into
mainfrom
fix/admin-ui-plugin-release-url

Conversation

@mo-auto

@mo-auto mo-auto commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary

jenkins.jans.io was shut off when the Janssen project moved artifact publishing from Jenkins to GitHub (Packages + release assets). flex-linux-setup still downloaded the admin-ui-plugin distribution jar from jenkins.jans.io/maven/..., so the download 404'd and admin-ui-plugin-<ver>-distribution.jar went missing from /opt/dist/jans/ in the flex packages.

Change

Route that one download through jans-linux-setup's base.determine_jans_artifact_url(...) (the helper flex_setup.py already imports), which builds the GitHub release asset URL .../releases/download/<tag>/admin-ui-plugin-<ver>-distribution.jar. The version comes from base.current_app.app_info['jans_version'] so the asset name and the release tag (nightly vs v<version>) both derive from the jans build being installed — exactly how jans-linux-setup fetches the auth-client and fido2 jars. The now-unused maven_base_url constant and urljoin import are removed.

The asset is published on the jans release (e.g. admin-ui-plugin-2.2.0-distribution.jar on v2.2.0).

The jenkins.gluu.org admin-ui-binary references (flex_setup.py adimin_ui_bin_url, docker-admin-ui) are Gluu's separate Jenkins and intentionally left out of this change.

Summary by CodeRabbit

  • Refactor
    • Improved the installation artifact resolution process by consolidating URL construction logic. The setup script now uses a centralized version-aware method to determine artifact locations instead of manual composition. This ensures consistent version handling when downloading installation components, particularly the admin-ui plugin.

…ease

jenkins.jans.io was shut off when Janssen moved artifact publishing to GitHub release assets, so
flex_setup.py's admin-ui-plugin download (jenkins.jans.io/maven/...) 404'd and
admin-ui-plugin-<ver>-distribution.jar was missing from /opt/dist/jans in the flex packages. Route it
through jans-linux-setup's base.determine_jans_artifact_url with app_info['jans_version'] - the same
helper jans-linux-setup uses for the auth-client/fido2 jars - so the asset name and release tag
(nightly vs v<version>) stay consistent with the jans build being installed. Drop the now-unused
maven_base_url constant and urljoin import.

Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

In flex_setup.py, the admin-UI plugin JAR download URL is switched from manual Maven URL construction (using urljoin, JANS_APP_VERSION, and JANS_BUILD) to base.determine_jans_artifact_url(...) with jans_version from base.current_app.app_info. The now-unused urljoin import and maven_base_url constant are removed.

Changes

Admin-UI JAR URL Source Refactor

Layer / File(s) Summary
Replace Maven URL construction with determine_jans_artifact_url
flex-linux-setup/flex_linux_setup/flex_setup.py
Removes urljoin from urllib.parse imports and deletes the maven_base_url constant; updates the admin-UI plugin JAR download URL from a manually composed urljoin(maven_base_url, ...) call to base.determine_jans_artifact_url(...) sourcing jans_version from base.current_app.app_info.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit once stitched URLs by paw,
Joining Maven paths with urljoin's law.
Now determine_jans_artifact_url knows the way,
No more maven_base_url rusting away!
🐇✨ One helper call, and the JAR finds its home.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: switching the admin-ui-plugin download from Maven to GitHub releases, which is the core fix for the broken artifact download.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/admin-ui-plugin-release-url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'flex_linux_setup'

Failed conditions
4 New Vulnerabilities (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mo-auto mo-auto added comp-flex-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jun 23, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@flex-linux-setup/flex_linux_setup/flex_setup.py`:
- Around line 365-368: The code references
base.current_app.app_info['jans_version'] in the determine_jans_artifact_url
call for the admin-ui-plugin artifact URL, but this key does not exist in
base.current_app.app_info and will cause a KeyError at runtime. Replace the
reference to base.current_app.app_info['jans_version'] with
app_versions['jans_version'] in the format string, since the local app_versions
dictionary (populated on line 146) contains the correctly computed jans_version
that combines JANS_APP_VERSION with JANS_BUILD.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 68bf482e-36f2-473e-a7bb-cda12aa378ba

📥 Commits

Reviewing files that changed from the base of the PR and between bc82d77 and dec452d.

📒 Files selected for processing (1)
  • flex-linux-setup/flex_linux_setup/flex_setup.py

Comment thread flex-linux-setup/flex_linux_setup/flex_setup.py
@moabu moabu merged commit e5f82d7 into main Jun 23, 2026
9 of 12 checks passed
@moabu moabu deleted the fix/admin-ui-plugin-release-url branch June 23, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-flex-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants