Skip to content

fix(flex-linux-setup): download apps approprieately#2899

Merged
devrimyatar merged 1 commit into
mainfrom
flex-linux-setup-2898
Jun 24, 2026
Merged

fix(flex-linux-setup): download apps approprieately#2899
devrimyatar merged 1 commit into
mainfrom
flex-linux-setup-2898

Conversation

@devrimyatar

@devrimyatar devrimyatar commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Closes #2898

Summary by CodeRabbit

  • Bug Fixes
    • Simplified the app setup download step so required application packages are fetched together, improving installation reliability.

Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar devrimyatar requested a review from duttarnab June 24, 2026 19:11
@devrimyatar devrimyatar added bug Something isn't working comp-flex-linux-setup Component affected by issue or PR labels Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 266c4f3c-1952-4d02-ba22-8146ac35e675

📥 Commits

Reviewing files that changed from the base of the PR and between 34040ea and 3b539d9.

📒 Files selected for processing (1)
  • flex-linux-setup/flex_linux_setup/flex_setup.py

📝 Walkthrough

Walkthrough

The installer now loads app_info.json into downloads.base.current_app.app_info and then calls downloads.download_apps() instead of separate dependency download functions.

Changes

App download invocation

Layer / File(s) Summary
App download call update
flex-linux-setup/flex_linux_setup/flex_setup.py
The app-download step now invokes downloads.download_apps() instead of the individual download_sqlalchemy, download_cryptography, and download_pyjwt calls.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

kind-bug

Suggested reviewers

  • moabu

Poem

I hopped to setup with a cheerful thump,
One download call replaced three little jumps.
The app pack lands in a simpler spree,
And my whiskers twitch with glee. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and matches the main change: fixing flex-linux-setup app downloads.
Linked Issues check ✅ Passed The change replaces the missing download_sqlalchemy call with the appropriate bulk app download flow, addressing #2898.
Out of Scope Changes check ✅ Passed No unrelated changes are evident beyond the app-download fix described in the issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch flex-linux-setup-2898

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Jun 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

@devrimyatar devrimyatar merged commit 7562ac4 into main Jun 24, 2026
10 of 12 checks passed
@devrimyatar devrimyatar deleted the flex-linux-setup-2898 branch June 24, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working comp-flex-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(flex-linux-setup): flex setyp fails

3 participants