core: soft nav timespan experiemental support#17075
Draft
ChristopherPHolder wants to merge 2 commits into
Draft
Conversation
ChristopherPHolder
requested review from
paulirish
and removed request for
a team
ChristopherPHolder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce experiemental support for soft navigations in lighthouse timespan
Notes
This is effort is in its early day, at this momemnt i am mostly experimenting in this PR with what is possible.
Many questions are still left on unanswered. Some documentation on those will be described here
Its likely that even if this PR succeeds in introducing soft navigations it will be incremental, starting by timespans and the navigations triguered via the callback and start/end navigation methods will introduce a lot of complexity.
Related Issues/PRs
Related: #14573