Skip to content

Updated PostgreSQLDialectAdapter to correctly map specific data types…#3983

Draft
jsuhani-2026 wants to merge 4 commits into
mainfrom
jsuhani-pg-indextype-mapping
Draft

Updated PostgreSQLDialectAdapter to correctly map specific data types…#3983
jsuhani-2026 wants to merge 4 commits into
mainfrom
jsuhani-pg-indextype-mapping

Conversation

@jsuhani-2026

Copy link
Copy Markdown
Contributor

Updated PostgreSQLDialectAdapter to correctly map specific data types to their appropriate IndexTypes

@jsuhani-2026 jsuhani-2026 added the addition New feature or request label Jul 3, 2026
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.64%. Comparing base (06d6601) to head (23b5852).

Files with missing lines Patch % Lines
...owmapper/provider/PostgreSQLJdbcValueMappings.java 68.57% 6 Missing and 5 partials ⚠️
...uniformsplitter/range/BoundarySplitterFactory.java 87.87% 2 Missing and 2 partials ⚠️
...rmsplitter/range/RangePreparedStatementSetter.java 82.60% 4 Missing ⚠️
...ctadapter/postgresql/PostgreSQLDialectAdapter.java 90.32% 1 Missing and 2 partials ⚠️
...er/migrations/avro/GenericRecordTypeConvertor.java 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3983      +/-   ##
============================================
+ Coverage     55.70%   63.64%   +7.93%     
+ Complexity     7237     2542    -4695     
============================================
  Files          1124      535     -589     
  Lines         68447    30907   -37540     
  Branches       7721     3446    -4275     
============================================
- Hits          38130    19670   -18460     
+ Misses        27843    10215   -17628     
+ Partials       2474     1022    -1452     
Components Coverage Δ
spanner-templates 88.08% <88.00%> (+0.41%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 89.21% <88.23%> (-0.09%) ⬇️
spanner-live-reverse-replication 83.41% <88.23%> (-0.06%) ⬇️
spanner-bulk-migration 92.36% <88.00%> (-0.12%) ⬇️
gcs-spanner-dv 89.97% <88.23%> (+1.42%) ⬆️
Files with missing lines Coverage Δ
...ort/v2/reader/io/jdbc/iowrapper/JdbcIoWrapper.java 98.10% <ø> (ø)
...niformsplitter/range/BoundaryExtractorFactory.java 98.97% <100.00%> (+0.26%) ⬆️
...ort/v2/reader/io/schema/SourceColumnIndexInfo.java 81.81% <100.00%> (+9.40%) ⬆️
...ource/postgres/PostgresSrcToSpSourceConnector.java 98.97% <100.00%> (+0.04%) ⬆️
...er/migrations/avro/GenericRecordTypeConvertor.java 95.90% <88.23%> (-0.38%) ⬇️
...ctadapter/postgresql/PostgreSQLDialectAdapter.java 93.66% <90.32%> (+0.12%) ⬆️
...uniformsplitter/range/BoundarySplitterFactory.java 97.16% <87.87%> (-1.72%) ⬇️
...rmsplitter/range/RangePreparedStatementSetter.java 92.85% <82.60%> (-5.11%) ⬇️
...owmapper/provider/PostgreSQLJdbcValueMappings.java 92.59% <68.57%> (-6.63%) ⬇️

... and 613 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsuhani-2026 jsuhani-2026 force-pushed the jsuhani-pg-indextype-mapping branch 4 times, most recently from 50fb009 to e72f892 Compare July 9, 2026 13:18
… (BOOL, TIME, UUID, etc.) to their appropriate IndexTypes

Updated the integration tests for PostgreSQL simple primary keys to make sure primary keys of all different data types migrate successfully.
@jsuhani-2026 jsuhani-2026 force-pushed the jsuhani-pg-indextype-mapping branch 6 times, most recently from 9444fa5 to 9691e10 Compare July 12, 2026 09:19
@jsuhani-2026 jsuhani-2026 force-pushed the jsuhani-pg-indextype-mapping branch from 9691e10 to 8b0175f Compare July 12, 2026 10:17
@jsuhani-2026 jsuhani-2026 force-pushed the jsuhani-pg-indextype-mapping branch from a6cfe2f to 23b5852 Compare July 13, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant