Fix the flaky load tests#4011
Conversation
shreyakhajanchi
commented
Jul 10, 2026
- Fixed DataStreamToSpannerBlobTableLT.java to use correct secret version for ip address
- Reverse replication load tests were falky due to small MySQL container added some flags to bypass the issue during MySQL container creation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses flakiness in load tests by updating secret configurations and optimizing the MySQL container environment. By introducing a custom resource manager, the tests now properly configure InnoDB settings, which improves stability during high-load scenarios. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4011 +/- ##
=============================================
+ Coverage 35.89% 55.70% +19.81%
- Complexity 716 7237 +6521
=============================================
Files 251 1124 +873
Lines 17152 68447 +51295
Branches 1738 7721 +5983
=============================================
+ Hits 6157 38130 +31973
- Misses 10483 27843 +17360
- Partials 512 2474 +1962
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request introduces a custom LTMySQLResourceManager and updates several Spanner-to-SourceDB load tests to use it instead of the standard MySQLResourceManager. It also configures both ShardedMySQLResourceManager and LTMySQLResourceManager with specific InnoDB settings (--innodb_buffer_pool_size=1G and --innodb_redo_log_capacity=1G). Feedback was provided regarding the use of --innodb_redo_log_capacity, which is only supported in MySQL 8.0.30 and newer; using --innodb_log_file_size=512M is recommended instead to maintain backward compatibility with older MySQL versions.