Skip to content

Fix the flaky load tests#4011

Merged
shreyakhajanchi merged 2 commits into
mainfrom
fix-lt
Jul 12, 2026
Merged

Fix the flaky load tests#4011
shreyakhajanchi merged 2 commits into
mainfrom
fix-lt

Conversation

@shreyakhajanchi

Copy link
Copy Markdown
Contributor
  1. Fixed DataStreamToSpannerBlobTableLT.java to use correct secret version for ip address
  2. Reverse replication load tests were falky due to small MySQL container added some flags to bypass the issue during MySQL container creation

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses flakiness in load tests by updating secret configurations and optimizing the MySQL container environment. By introducing a custom resource manager, the tests now properly configure InnoDB settings, which improves stability during high-load scenarios.

Highlights

  • Secret Configuration Update: Updated the secret version for the IP address in DataStreamToSpannerBlobTableLT.java to ensure correct connectivity.
  • MySQL Container Optimization: Introduced LTMySQLResourceManager to configure MySQL containers with increased InnoDB buffer pool and redo log capacity, addressing flakiness in reverse replication load tests.
  • Refactored Test Infrastructure: Migrated existing load tests to utilize the new LTMySQLResourceManager, ensuring consistent container configurations across the test suite.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.70%. Comparing base (24c2ac7) to head (ef4218b).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #4011       +/-   ##
=============================================
+ Coverage     35.89%   55.70%   +19.81%     
- Complexity      716     7237     +6521     
=============================================
  Files           251     1124      +873     
  Lines         17152    68447    +51295     
  Branches       1738     7721     +5983     
=============================================
+ Hits           6157    38130    +31973     
- Misses        10483    27843    +17360     
- Partials        512     2474     +1962     
Components Coverage Δ
spanner-templates 87.66% <ø> (∅)
spanner-import-export 68.70% <ø> (∅)
spanner-live-forward-migration 89.29% <ø> (∅)
spanner-live-reverse-replication 83.46% <ø> (∅)
spanner-bulk-migration 92.48% <ø> (∅)
gcs-spanner-dv 88.55% <ø> (∅)
see 898 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a custom LTMySQLResourceManager and updates several Spanner-to-SourceDB load tests to use it instead of the standard MySQLResourceManager. It also configures both ShardedMySQLResourceManager and LTMySQLResourceManager with specific InnoDB settings (--innodb_buffer_pool_size=1G and --innodb_redo_log_capacity=1G). Feedback was provided regarding the use of --innodb_redo_log_capacity, which is only supported in MySQL 8.0.30 and newer; using --innodb_log_file_size=512M is recommended instead to maintain backward compatibility with older MySQL versions.

@darshan-sj darshan-sj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyakhajanchi shreyakhajanchi merged commit 06d6601 into main Jul 12, 2026
44 of 48 checks passed
@shreyakhajanchi shreyakhajanchi deleted the fix-lt branch July 12, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants