Refactor spanner-staging-tests and rectify InformationSchemaScannerIT#4017
Draft
aasthabharill wants to merge 4 commits into
Draft
Refactor spanner-staging-tests and rectify InformationSchemaScannerIT#4017aasthabharill wants to merge 4 commits into
aasthabharill wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4017 +/- ##
============================================
- Coverage 55.70% 55.68% -0.03%
+ Complexity 7235 6782 -453
============================================
Files 1124 1124
Lines 68447 68447
Branches 7721 7721
============================================
- Hits 38128 38114 -14
- Misses 27844 27858 +14
Partials 2475 2475
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/531449982
This PR refactors the Spanner staging integration test pipeline to dynamically adapt to different testing environments (Production, Staging, Cloud-devel). It improves pipeline visibility in GitHub Actions and ensures test reliability across Spanner hosts with differing multi-region provisioning.
Changes and Intent
1. Added a dynamic
run-nameexpression in.github/workflows/spanner-staging-tests.ymlBecause this workflow runs against three different Spanner hosts (Prod, Staging, Cloud-devel), distinguishing the runs in the GitHub Actions UI was difficult. Test runs will now clearly identify their target environment (e.g., "Spanner Cloud-devel Integration Tests").
2. Removed the explicit
spannerHostinput configuration from thepull_requestblock to avoid masking defaultspull_requesttriggers don't accept theinputsparameter - so the workflow that this PR triggered had no Spanner host set, which is incorrect. (Workflow link)envblock to rectify this issue3. Added a
spannerMultiRegioninput parameter to the workflow.spannerHost: it defaults tonam-private1for staging, and falls back tonam3for all other environments.--it-spanner-multi-regionflag to the Go test wrappers (it-flags.go,run-spanner-staging-it-tests/main.go) to pass the environment variable down to Maven as a system property.InformationSchemaScannerIT.javato construct theSpannerResourceManagerusingSystem.getProperty("spannerMultiRegion", "nam3")instead of hardcoding specific multi-regions or relying on custom instance partitions.Intent:
nam3were hardcoded inside the Java tests.nam3is not universally provisioned across all our test environments (like Staging), tests would fail depending on the host.4. Changed
PARTITION_IDtodefaultinstead of creating a new one"default"that shares the instance's region configuration.nam3), and the custom partition must be created in a different configuration (e.g.,nam6).Tests
https://screenshot.googleplex.com/4Ew96Vt3ckq9mnh.png