Use config_override nodepools rather than in-benchmark nodepool for Karpenter GPUs#6687
Merged
Conversation
…arpenter GPUs This replaces "if Karpenter" logic in the benchmark. Moving the logic here also let me more easily set what instance families would be allowed (rather than using hardcoded ones). PiperOrigin-RevId: 919149807
copybara-service
Bot
force-pushed
the
test_917507435
branch
from
cace246 to
dcaa7d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use config_override nodepools rather than in-benchmark nodepool for Karpenter GPUs
This replaces "if Karpenter" logic in the benchmark. Moving the logic here also let me more easily set what instance families would be allowed (rather than using hardcoded ones).