Add networkutils specialized instance creation, use it in networkconfig#539
Open
copybara-service[bot] wants to merge 1 commit into
Open
Add networkutils specialized instance creation, use it in networkconfig#539copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_932677032
branch
from
794b77d to
6f9762e
Compare
Testing with `networkconfig` and the previous test harness (which was trying to use GVNIC, but wasn't really): > no config expectation found for machine type "n2-highcpu-32" and nic types [GVNIC] This is exactly what we want to see. We will add updated test expectations for GVNIC in a later change. PiperOrigin-RevId: 932677032
copybara-service
Bot
force-pushed
the
test_932677032
branch
from
6f9762e to
e560f9d
Compare
|
@copybara-service[bot]: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add networkutils specialized instance creation, use it in networkconfig
Testing with
networkconfigand the previous test harness (which wastrying to use GVNIC, but wasn't really):
This is exactly what we want to see. We will add updated test
expectations for GVNIC in a later change.