Isolate Daily Test to run without any interference from other resources #5556
Isolate Daily Test to run without any interference from other resources #5556LAVEEN wants to merge 7 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces logic to allow multiple builds to run in parallel by enhancing the build check mechanism. By incorporating a test prefix and an on-spot status flag, the system can now differentiate between concurrent build instances, enabling both PR-based and daily scheduled runs to execute simultaneously without conflict. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the check_running_build.sh script and its usage in various YAML build files to support prefix-based filtering for parallel builds. My review identified several critical issues: the validation script tools/cloud-build/daily-tests/validate_daily_test_builds.py must be updated to accommodate the new script arguments, and the ${_TEST_PREFIX} variable in all modified YAML files must be quoted to prevent shell argument shifting when the prefix is empty. Additionally, I have suggested a logic improvement to ensure prefix-based filtering is applied more consistently, rather than being restricted only to on-spot builds.
This pull request introduces logic to enable parallel execution of integration tests in the Cluster Toolkit, specifically allowing a Pull Request (PR) test and a Daily scheduled test for the same blueprint to run concurrently without conflict .
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.