Skip to content

Isolate Daily Test to run without any interference from other resources #5556

Draft
LAVEEN wants to merge 7 commits into
GoogleCloudPlatform:developfrom
LAVEEN:parallelexec
Draft

Isolate Daily Test to run without any interference from other resources #5556
LAVEEN wants to merge 7 commits into
GoogleCloudPlatform:developfrom
LAVEEN:parallelexec

Conversation

@LAVEEN
Copy link
Copy Markdown
Collaborator

@LAVEEN LAVEEN commented Apr 25, 2026

This pull request introduces logic to enable parallel execution of integration tests in the Cluster Toolkit, specifically allowing a Pull Request (PR) test and a Daily scheduled test for the same blueprint to run concurrently without conflict .

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces logic to allow multiple builds to run in parallel by enhancing the build check mechanism. By incorporating a test prefix and an on-spot status flag, the system can now differentiate between concurrent build instances, enabling both PR-based and daily scheduled runs to execute simultaneously without conflict.

Highlights

  • Parallel Execution Logic: Updated the build check script to support parallel execution by filtering builds based on a test prefix and an optional 'on-spot' flag.
  • Configuration Updates: Modified numerous daily test YAML configurations to pass the new test prefix and on-spot parameters to the build check script.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the check_running_build.sh script and its usage in various YAML build files to support prefix-based filtering for parallel builds. My review identified several critical issues: the validation script tools/cloud-build/daily-tests/validate_daily_test_builds.py must be updated to accommodate the new script arguments, and the ${_TEST_PREFIX} variable in all modified YAML files must be quoted to prevent shell argument shifting when the prefix is empty. Additionally, I have suggested a logic improvement to ensure prefix-based filtering is applied more consistently, rather than being restricted only to on-spot builds.

Comment thread tools/cloud-build/check_running_build.sh
Comment thread tools/cloud-build/daily-tests/builds/ansible-vm.yaml Outdated
Comment thread tools/cloud-build/daily-tests/builds/gke-a2-highgpu-kueue-onspot.yaml Outdated
Comment thread tools/cloud-build/check_running_build.sh
@LAVEEN LAVEEN added the release-chore To not include into release notes label Apr 25, 2026
@LAVEEN LAVEEN changed the title Adding Parallel Execution Logic To Allow 1 PR & 1 DAILY Run Parallelly Isolate Daily Test to run without any interference from other resources Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant