Skip to content

update NCCL gIB version to 1.1.2#5674

Open
wendiliao wants to merge 1 commit into
GoogleCloudPlatform:developfrom
wendiliao:update-nccl-gIB-v1.1.2
Open

update NCCL gIB version to 1.1.2#5674
wendiliao wants to merge 1 commit into
GoogleCloudPlatform:developfrom
wendiliao:update-nccl-gIB-v1.1.2

Conversation

@wendiliao
Copy link
Copy Markdown

This PR updates the NCCL gIB plugin version to 1.1.2

@wendiliao wendiliao requested a review from a team as a code owner May 15, 2026 19:20
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the configuration for the A3 Ultra custom image blueprint to utilize newer versions of the NCCL gIB plugin and the NCCL library. These adjustments ensure that the daily test environments remain current with the latest software dependencies.

Highlights

  • NCCL gIB Version Update: Updated the NCCL gIB plugin version to 1.1.2 within the A3 Ultra custom image blueprint.
  • NCCL Library Update: Updated the libnccl version to 2.30.4-1+cuda13.0 to align with the latest environment requirements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the nccl_gib_version to 1.1.2 and the libnccl_version to 2.30.4-1+cuda13.0 in the a3ultra-custom-image-blueprint.yaml file. Feedback was provided noting that the PR description needs to be updated to include the libnccl_version and CUDA version changes to comply with the repository style guide.

nccl_gib_version: 1.1.0
libnccl_version: 2.27.5-1+cuda12.9
nccl_gib_version: 1.1.2
libnccl_version: 2.30.4-1+cuda13.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR description only mentions updating the NCCL gIB plugin version to 1.1.2. However, this change also includes a significant update to libnccl_version, moving from 2.27.5-1+cuda12.9 to 2.30.4-1+cuda13.0. Per the repository style guide, the PR description should clearly explain the purpose of all changes. Please update the PR description to reflect the NCCL and CUDA version updates.

References
  1. The PR description should clearly explain the purpose of the change and the problem it solves. (link)

@aslam-quad aslam-quad changed the base branch from main to develop May 18, 2026 05:56
@aslam-quad aslam-quad added the external PR from external contributor label May 18, 2026
@aslam-quad
Copy link
Copy Markdown
Contributor

/gcbrun

@mufaqam-gcl mufaqam-gcl requested a review from LAVEEN May 19, 2026 06:26
@LAVEEN
Copy link
Copy Markdown
Collaborator

LAVEEN commented May 21, 2026

Hi @wendiliao , there seems to be some merge conflict , could you please check and resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants