update NCCL gIB version to 1.1.2#5674
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the configuration for the A3 Ultra custom image blueprint to utilize newer versions of the NCCL gIB plugin and the NCCL library. These adjustments ensure that the daily test environments remain current with the latest software dependencies. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the nccl_gib_version to 1.1.2 and the libnccl_version to 2.30.4-1+cuda13.0 in the a3ultra-custom-image-blueprint.yaml file. Feedback was provided noting that the PR description needs to be updated to include the libnccl_version and CUDA version changes to comply with the repository style guide.
| nccl_gib_version: 1.1.0 | ||
| libnccl_version: 2.27.5-1+cuda12.9 | ||
| nccl_gib_version: 1.1.2 | ||
| libnccl_version: 2.30.4-1+cuda13.0 |
There was a problem hiding this comment.
The PR description only mentions updating the NCCL gIB plugin version to 1.1.2. However, this change also includes a significant update to libnccl_version, moving from 2.27.5-1+cuda12.9 to 2.30.4-1+cuda13.0. Per the repository style guide, the PR description should clearly explain the purpose of all changes. Please update the PR description to reflect the NCCL and CUDA version updates.
References
- The PR description should clearly explain the purpose of the change and the problem it solves. (link)
|
/gcbrun |
|
Hi @wendiliao , there seems to be some merge conflict , could you please check and resolve. |
This PR updates the NCCL gIB plugin version to
1.1.2