fix(setup): fix gcloud taxonomy filter and resolve import conflicts using project-suffixed display name#1374
Merged
Conversation
…sing project-suffixed display name
Lsubatin
approved these changes
Jun 17, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the setup_lab.sh script to handle potential taxonomy name conflicts by appending the project ID to the taxonomy display name (LostCargoSecurity_${PROJECT_ID}) and queries the taxonomy using displayName instead of display_name. The review feedback identifies potential SIGPIPE (exit code 141) issues caused by using awk with exit or head -n 1 in pipelines when set -o pipefail is enabled. It suggests leveraging gcloud's built-in filtering capabilities and using awk 'NR==1' to safely extract the first match without closing the pipe early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.