Skip to content

Cover agentconfig functionality by unit tests#925

Open
iliatsuprik wants to merge 2 commits into
GoogleCloudPlatform:masterfrom
iliatsuprik:agentconfig-unittests
Open

Cover agentconfig functionality by unit tests#925
iliatsuprik wants to merge 2 commits into
GoogleCloudPlatform:masterfrom
iliatsuprik:agentconfig-unittests

Conversation

@iliatsuprik
Copy link
Copy Markdown
Contributor

@iliatsuprik iliatsuprik commented Mar 12, 2026

This PR contains unit tests and minor changes in code for github.com/GoogleCloudPlatform/osconfig/agentconfig package.
Initial coverage: 58.1%, current coverage: 96.4%

Changes in the code of main app:

  • move 5 seconds retry interval and runtime.GOOS into global variable. That's needed for mocking it in tests

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Mar 12, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow google-oss-prow Bot requested a review from burov March 12, 2026 18:49
@google-oss-prow google-oss-prow Bot requested a review from savija-tv March 12, 2026 18:49
@google-oss-prow
Copy link
Copy Markdown

google-oss-prow Bot commented Mar 12, 2026

Hi @iliatsuprik. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@burov
Copy link
Copy Markdown
Member

burov commented Mar 13, 2026

/gcbrun

2 similar comments
@burov
Copy link
Copy Markdown
Member

burov commented Mar 13, 2026

/gcbrun

@burov
Copy link
Copy Markdown
Member

burov commented Mar 13, 2026

/gcbrun

@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch from 9b2e8c2 to c555736 Compare March 16, 2026 11:40
@burov
Copy link
Copy Markdown
Member

burov commented Mar 16, 2026

/gcbrun

burov
burov reviewed Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@burov burov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might benefit from using table driven testing more often in this CL, as well i see a lot of code duplication in test set-up, some of the code repetitions are low hanging fruits and can be just extracted to separate function as is.

Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go
Comment thread agentconfig/agentconfig_test.go
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch 2 times, most recently from dd95306 to 3310076 Compare March 17, 2026 19:01
@iliatsuprik
Copy link
Copy Markdown
Contributor Author

iliatsuprik commented Mar 17, 2026

@burov, thanks for the comprehensive review. I refactored most of the tests according to your comments. Could you check them again?

@burov
Copy link
Copy Markdown
Member

burov commented Mar 18, 2026

/gcbrun

@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch 2 times, most recently from 6abe8ad to ca292c6 Compare March 30, 2026 08:55
@burov
Copy link
Copy Markdown
Member

burov commented Mar 30, 2026

/gcbrun

3 similar comments
@burov
Copy link
Copy Markdown
Member

burov commented Mar 30, 2026

/gcbrun

@burov
Copy link
Copy Markdown
Member

burov commented Mar 30, 2026

/gcbrun

@burov
Copy link
Copy Markdown
Member

burov commented Mar 30, 2026

/gcbrun

@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch from 1a0833a to 827938f Compare April 7, 2026 09:03
@burov
Copy link
Copy Markdown
Member

burov commented Apr 13, 2026

/gcbrun

@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch 2 times, most recently from 657e073 to 98d848a Compare April 27, 2026 15:17
@petercieslak
Copy link
Copy Markdown
Contributor

petercieslak commented Apr 27, 2026

/gcbrun

petercieslak
petercieslak previously approved these changes Apr 27, 2026
View reviewed changes
@google-oss-prow google-oss-prow Bot added the lgtm label Apr 27, 2026
@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch 5 times, most recently from be3e6da to a1cf3c3 Compare May 11, 2026 11:19
@burov
Copy link
Copy Markdown
Member

burov commented May 11, 2026

/gcbrun

petercieslak
petercieslak previously approved these changes May 12, 2026
View reviewed changes
@google-oss-prow google-oss-prow Bot added lgtm and removed lgtm labels May 12, 2026
@google-oss-prow
Copy link
Copy Markdown

google-oss-prow Bot commented May 12, 2026

New changes are detected. LGTM label has been removed.

@petercieslak
Copy link
Copy Markdown
Contributor

petercieslak commented May 12, 2026

/gcbrun

6 similar comments
@petercieslak
Copy link
Copy Markdown
Contributor

petercieslak commented May 12, 2026

/gcbrun

@petercieslak
Copy link
Copy Markdown
Contributor

petercieslak commented May 12, 2026

/gcbrun

@petercieslak
Copy link
Copy Markdown
Contributor

petercieslak commented May 12, 2026

/gcbrun

@petercieslak
Copy link
Copy Markdown
Contributor

petercieslak commented May 12, 2026

/gcbrun

@petercieslak
Copy link
Copy Markdown
Contributor

petercieslak commented May 12, 2026

/gcbrun

@petercieslak
Copy link
Copy Markdown
Contributor

petercieslak commented May 12, 2026

/gcbrun

burov
burov reviewed May 12, 2026
View reviewed changes
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go
Comment thread agentconfig/agentconfig_test.go Outdated
@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch from 33218ac to 2064d2a Compare May 13, 2026 11:52
@google-oss-prow
Copy link
Copy Markdown

google-oss-prow Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iliatsuprik
Once this PR has been reviewed and has the lgtm label, please assign paulinakania for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@google-oss-prow
Copy link
Copy Markdown

google-oss-prow Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iliatsuprik
Once this PR has been reviewed and has the lgtm label, please assign paulinakania for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch from 2064d2a to 35d4649 Compare May 13, 2026 11:58
@burov
Copy link
Copy Markdown
Member

burov commented May 14, 2026

/gcbrun

1 similar comment
@burov
Copy link
Copy Markdown
Member

burov commented May 14, 2026

/gcbrun

burov
burov reviewed May 14, 2026
View reviewed changes
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
Comment thread agentconfig/agentconfig_test.go Outdated
@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch from dd1f2f4 to b067b13 Compare May 15, 2026 16:52
@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch from b067b13 to 4bfd8db Compare May 18, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burov burov burov left review comments

@petercieslak petercieslak petercieslak left review comments

@savija-tv savija-tv Awaiting requested review from savija-tv

At least 2 approving reviews are required to merge this pull request.

Assignees

@petercieslak petercieslak

Labels

needs-ok-to-test size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iliatsuprik @burov @petercieslak