Skip to content

chore(deps): bump golang.org/x/net to v0.53.0#1921

Merged
bwplotka merged 1 commit into
GoogleCloudPlatform:mainfrom
brtkwr:bump-golang-x-net
May 20, 2026
Merged

chore(deps): bump golang.org/x/net to v0.53.0#1921
bwplotka merged 1 commit into
GoogleCloudPlatform:mainfrom
brtkwr:bump-golang-x-net

Conversation

@brtkwr
Copy link
Copy Markdown
Contributor

@brtkwr brtkwr commented May 15, 2026

Resolves the govulncheck failure currently affecting every PR against main:

Vulnerability #1: GO-2026-4918
Infinite loop in HTTP/2 transport when given bad SETTINGS_MAX_FRAME_SIZE in
net/http/internal/http2 in golang.org/x/net
Module: golang.org/x/net
Found in: golang.org/x/net@v0.48.0
Fixed in: golang.org/x/net@v0.53.0
Example traces found:
#1: e2e/kube/pod.go:44:28: kube.PodLogs calls rest.Request.Stream, which eventually calls http2.Transport.NewClientConn

Bumping the indirect golang.org/x/net dependency to v0.53.0. go mod tidy after the bump also rolls forward the sibling golang.org/x/sys, golang.org/x/term, and golang.org/x/text modules to the versions pulled in transitively by x/net v0.53.

Test plan

  • go build ./... clean
  • go test ./pkg/operator/... passes (unit tests)
  • e2e tests not runnable locally without a kind cluster, but the diff is dependency-only — no behavior changes
  • govulncheck ./... should no longer report GO-2026-4918 after this (couldn't verify locally without the tool but the version table is unambiguous)

cc @bwplotka @lyanco @bernot-dev @pintohutch — flagged from #1920 where govulncheck blocks unrelated work; rebasing that PR on top of this one as soon as it merges.

Fixes GO-2026-4918 (infinite loop in HTTP/2 transport on bad
SETTINGS_MAX_FRAME_SIZE in net/http/internal/http2), reached as an
indirect dependency via e2e/kube/pod.go -> rest.Request.Stream ->
http2.Transport.NewClientConn.

`go mod tidy` after the bump also rolls golang.org/x/sys
(v0.39.0 -> v0.43.0), golang.org/x/term (v0.38.0 -> v0.42.0), and
golang.org/x/text (v0.32.0 -> v0.36.0) to the versions pulled in
transitively by x/net v0.53.
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Go sub-repository dependencies, including golang.org/x/mod, golang.org/x/crypto, golang.org/x/net, golang.org/x/sync, golang.org/x/sys, golang.org/x/term, golang.org/x/text, and golang.org/x/tools, to their latest versions in go.mod and go.sum. I have no feedback to provide as there are no review comments.

Copy link
Copy Markdown
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

We need to revive dependabot/renovate, got stuck it seems.

@bwplotka bwplotka merged commit b14025c into GoogleCloudPlatform:main May 20, 2026
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants