feat(forms): bound SearchPage query length with accessible feedback (#271)#369
Open
jd5073356-max wants to merge 1 commit into
Open
feat(forms): bound SearchPage query length with accessible feedback (#271)#369jd5073356-max wants to merge 1 commit into
jd5073356-max wants to merge 1 commit into
Conversation
…rainlify#271) The dashboard search input had no length bound or feedback, so very long pasted queries were silently debounced and sent to search. - Add maxLength={100} to the search input. - Show an aria-live character counter as the query approaches the limit, with a "Character limit reached" message at the cap. - Trim leading/trailing whitespace before searching (debounce unchanged). - Extend SearchPage tests: maxLength attribute, counter near/at the limit, trimmed query matching, and whitespace-only handling. Closes Grainlify#271
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #271
What
The dashboard search input (
src/features/dashboard/pages/SearchPage.tsx) had no length bound and no feedback, so a user could paste a massive query that was silently debounced and searched.Changes
maxLength={100}on the search input (MAX_SEARCH_LENGTHconstant).aria-live="polite"counter appears once the query is within 20 characters of the limit, showing{length}/100, and announcesCharacter limit reachedat the cap. The input is wired witharia-describedby="search-input-counter".debouncedQuery.trim().toLowerCase(), so padded queries match cleanly and whitespace-only queries yield no results. The existing 300ms debounce (useDebouncedValue) is unchanged.Tests
Extended
SearchPage.test.tsx(existing 9 tests still pass) with: maxLength attribute enforced, counter hidden for short queries, counter shown witharia-livewhen approaching the limit, "limit reached" announced at the cap, trimmed query returns results, whitespace-only treated as empty.Verification
npm run typecheck— passes.SearchPage.test.tsx— 15/15 pass. Coverage ofSearchPage.tsx: 100% lines / 100% statements / 100% functions.Security
The length cap reduces the oversized-query payload surface sent to the backend.