Only show a snackbar when QR scan result is copied for Android 12 and lower#638
Closed
mrxx0 wants to merge 0 commit into
Closed
Only show a snackbar when QR scan result is copied for Android 12 and lower#638mrxx0 wants to merge 0 commit into
mrxx0 wants to merge 0 commit into
Conversation
Member
|
The system clipboard preview isn't shown by the OS in secondary users. |
mrxx0
force-pushed
the
remove-snackbar-copy-clipboard
branch
from
8e83432 to
1b5c4f1
Compare
mrxx0
force-pushed
the
remove-snackbar-copy-clipboard
branch
from
1b5c4f1 to
3d1d1ff
Compare
Member
Author
|
Closed by mistake, reopened at #639
Thank you for the review, I fixed it |
Member
|
Secondary users aren't the same thing as non-system users. Profiles of the main user are not affected by this issue. I think it would be better to add a feedback for the "copy action" on top of the copy button instead. |
Member
Author
What do you think of an UI feedback like this ? 
In case of extremely long url |
Member
|
Looks fine, but the color should be dynamic. |
Member
Author
|
Updated, #639 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid duplicate notifications and to follow android guidelines for the copy to clipboard this PR disable the snackbar when user copy the QR scan result on Android 13 and upper and keep it for Android 12 and lower.
Closes #619