Telecom: allow Android Auto to resolve PhoneAccounts for SIM disambiguation#25
Open
mroetsc wants to merge 1 commit into
Open
Conversation
…uation canGetPhoneAccount() blocks AA since it cannot hold READ_PRIVILEGED_PHONE_STATE as a sandboxed app. Mirrors the existing carve-out in getUserSelectedOutgoingPhoneAccount. Fixes: GrapheneOS/os-issue-tracker#3166
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue: GrapheneOS/os-issue-tracker#3166
I mirrored the permission used in
getUserSelectedOutgoingPhoneAccount:platform_packages_services_Telecomm/src/com/android/server/telecom/TelecomServiceImpl.java
Line 396 in c96509c
to add a similar case to
canGetPhoneAccount, since Android Auto is running sandboxed and can therefore not match against any of the other required permissions.For the
try/catchI used the same logic as in the clause above:platform_packages_services_Telecomm/src/com/android/server/telecom/TelecomServiceImpl.java
Lines 3881 to 3888 in c96509c