Skip to content

Harden package validator and list graphify_rank_files #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xkaushik-ai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Harden package validator and list graphify_rank_files #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85d4f2a
Harden package validator and list graphify_rank_files
0xkaushik-ai Oct 22, 2026
70637f7
Reject symlinked plugin directories
0xkaushik-ai Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/graphify/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ approval annotations. Availability can vary with server configuration and access
| --- | --- |
| `list_workspaces`, `list_repositories` | Discover accessible scope and repository IDs. |
| `set_workspace` | Select the active workspace and update the account's default workspace. |
| `query_graph`, `graphify_find`, `graphify_node` | Search indexed code and inspect symbols. |
| `query_graph`, `graphify_find`, `graphify_rank_files`, `graphify_node` | Search indexed code, find relevant files, and inspect symbols. |
| `graphify_callers`, `graphify_callees`, `graphify_trace` | Investigate directed call relationships. |
| `shortest_path` | Find a connecting graph path, which need not be a directed call chain. |
| `graphify_impact`, `impact_and_risk`, `graphify_tests_for` | Explore potential change impact and linked tests. These do not execute tests. |
Expand Down
30 changes: 23 additions & 7 deletions scripts/validate-template.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,18 @@
import { promises as fs } from "node:fs";
import path from "node:path";
import process from "node:process";
import { fileURLToPath } from "node:url";

const repoRoot = process.cwd();
const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
const errors = [];

const pluginNamePattern = /^[a-z0-9](?:[a-z0-9.-]*[a-z0-9])?$/;
const marketplaceNamePattern = /^[a-z0-9](?:[a-z0-9-]*[a-z0-9])?$/;

function addError(message) {
errors.push(message);
if (!errors.includes(message)) {
errors.push(message);
}
}

async function pathExists(targetPath) {
Expand All @@ -30,6 +33,12 @@ async function ensureDirectory(targetPath, context) {
addError(`${context} exists but is not a directory: ${targetPath}`);
return false;
}
// Reject the directory itself, or any parent inside the repo, being a symlink.
const realRelative = path.relative(await fs.realpath(repoRoot), await fs.realpath(targetPath));
if (realRelative !== path.relative(repoRoot, targetPath)) {
addError(`${context} must not be or sit under a symlink: ${path.relative(repoRoot, targetPath)}`);
return false;
}
return true;
} catch {
addError(`${context} directory is missing: ${targetPath}`);
Expand Down Expand Up @@ -69,12 +78,12 @@ function parseFrontmatter(content) {
return null;
}

const closingIndex = normalized.indexOf("\n---\n", 4);
if (closingIndex === -1) {
const closing = /\n---(?:\n|$)/.exec(normalized.slice(3));
if (!closing) {
return null;
}

const frontmatterBlock = normalized.slice(4, closingIndex);
const frontmatterBlock = normalized.slice(4, closing.index + 3);
const fields = {};

for (const line of frontmatterBlock.split("\n")) {
Expand All @@ -87,7 +96,7 @@ function parseFrontmatter(content) {
continue;
}
const key = line.slice(0, separator).trim();
const value = line.slice(separator + 1).trim();
const value = line.slice(separator + 1).trim().replace(/^(["'])(.*)\1$/, "$2").trim();
fields[key] = value;
}

Expand All @@ -107,6 +116,8 @@ async function walkFiles(dirPath) {
stack.push(entryPath);
} else if (entry.isFile()) {
files.push(entryPath);
} else if (entry.isSymbolicLink()) {
addError(`Symlinks are not allowed in plugin packages: ${path.relative(repoRoot, entryPath)}`);
}
}
}
Expand Down Expand Up @@ -248,6 +259,10 @@ async function validateGraphifyPackage(pluginDir, manifest, marketplaceVersion)
addError(`graphify: required package file is missing: ${file}`);
}
}
await walkFiles(pluginDir);
if (manifest.hooks !== undefined || (await pathExists(path.join(pluginDir, "hooks")))) {
addError("graphify: hooks are not allowed; the package must not run local code.");
}
if (manifest.mcpServers !== undefined) {
addError("graphify: keep the OAuth connection in the default mcp.json, without a manifest override.");
}
Expand Down Expand Up @@ -301,10 +316,11 @@ async function main() {
return;
}

const pluginRoot = marketplace.metadata?.pluginRoot;
let pluginRoot = marketplace.metadata?.pluginRoot;
if (pluginRoot !== undefined) {
if (typeof pluginRoot !== "string" || !isSafeRelativePath(pluginRoot)) {
addError('Marketplace "metadata.pluginRoot" must be a safe relative path.');
pluginRoot = undefined;
} else {
const pluginRootAbs = path.join(repoRoot, pluginRoot);
await ensureDirectory(pluginRootAbs, 'Marketplace "metadata.pluginRoot"');
Expand Down