fix(cli): hermes install --help text omits its AGENTS.md write#1849
Open
Mohak-Agrawal wants to merge 1 commit into
Open
fix(cli): hermes install --help text omits its AGENTS.md write#1849Mohak-Agrawal wants to merge 1 commit into
Mohak-Agrawal wants to merge 1 commit into
Conversation
…ify-Labs#1846) Bare `graphify hermes install` (no --project) dispatches to the same _agents_install() helper aider/codex/opencode/claw/droid/trae/trae-cn use to write a graphify section into AGENTS.md — confirmed by reading install.py's dispatch_install_cli(). But unlike every sibling platform's --help line (which says "write graphify section to AGENTS.md (Aider)" etc.), hermes's line only said "write skill to ~/.hermes/skills/graphify/ (Hermes)", with no mention of AGENTS.md at all — the exact silent-mutation trust-boundary concern the issue raises. README.md already documented this correctly (line 681: "AGENTS.md + ~/.hermes/skills/"), so this was a --help-text-only staleness, not a behavior bug. No runtime change: hermes stays grouped with its 8 sibling AGENTS.md-writing platforms, which is architecturally intentional and symmetric (same uninstall path removes the section too). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1846.
Bare
graphify hermes install(no--project) dispatches to the same_agents_install()helper thataider/codex/opencode/claw/droid/trae/trae-cnuse to write a graphify section intoAGENTS.md(seeinstall.py'sdispatch_install_cli(), the sharedelif cmd in ("aider", "codex", "opencode", "claw", "droid", "trae", "trae-cn", "hermes"):branch). So it does write toAGENTS.md— confirmed by reading the dispatch code.But unlike every sibling platform's
--helpline, which says exactly what it does ("write graphify section to AGENTS.md (Aider)", etc.), hermes's line only said:No mention of
AGENTS.mdat all — which is the silent-mutation / trust-boundary concern the issue raises.README.mdalready documents this correctly (graphify hermes install # AGENTS.md + ~/.hermes/skills/ (Hermes)), so this was--help-text staleness specifically, not a behavior bug.What changed
Updated the two
hermes install/hermes uninstalllines in__main__.py's help output to mention theAGENTS.mdsection, matching the phrasing pattern used by every sibling AGENTS.md-writing platform and matching what README.md already says.No runtime behavior change — hermes stays grouped with its 8 sibling platforms that write/remove an AGENTS.md section on install/uninstall, which looks architecturally intentional and symmetric (uninstall correctly removes the section too). Happy to also look at making the behavior itself opt-in/declared at write-time if maintainers would prefer that over just fixing the help text — flagging that as an option per the issue's two suggested resolutions, but went with the smaller, non-behavior-changing fix first.
Test plan
python3 -c "import ast; ast.parse(open('graphify/__main__.py').read())"— syntax validhermes installreally does route through_agents_install(), same as its AGENTS.md-writing siblings🤖 Generated with Claude Code