Add node macro support for injecting nodes into global scope

[timon-schelling]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces a Preprocessor struct to manage node substitutions and scope injections, replacing the previous static expand_network function. It adds support for an inject_scope attribute in node macros, allowing nodes to expose their scope to other consumer nodes. A critical issue was identified in the preprocessor's network expansion logic, where removing scope injections from the parent network prevents other external consumer nodes from resolving that scope.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Removing the scope injection from the parent network's scope_injections map will prevent any other consumer nodes at the parent level (or in other nested networks) from resolving this scope.

Since the producer node (producer_id) still exists in the parent network (it has just been substituted with a Network implementation), it remains a valid node that other parent-level consumers can reference. By keeping the scope injection in the parent network, we allow both internal consumers (inside the producer's nested network) and external consumers (at the parent level) to correctly resolve the scope.

We should avoid removing the key from network.scope_injections.

						for (key, ty) in matching_scope_injections {
							node_network.scope_injections.insert(key, (export_id, ty));
						}

[cubic-dev-ai]

1 issue found across 11 files

Confidence score: 5/5

• This PR looks low risk to merge: the only reported issue is low severity (3/10) and appears to affect node presentation rather than core runtime behavior.
• In node-graph/nodes/gcore/src/debug.rs, test-only inject-scope nodes are being registered as production Debug nodes, which could confuse users and clutter the visible node surface with no-op entries.
• Pay close attention to node-graph/nodes/gcore/src/debug.rs - ensure test-only inject-scope nodes are gated so they don’t appear as regular production Debug nodes.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/nodes/gcore/src/debug.rs">

<violation number="1" location="node-graph/nodes/gcore/src/debug.rs:39">
P3: Test-only inject-scope nodes are being added as regular production Debug nodes, which can mislead users and clutter the node surface with no-op scaffolding.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P3: Test-only inject-scope nodes are being added as regular production Debug nodes, which can mislead users and clutter the node surface with no-op scaffolding.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At node-graph/nodes/gcore/src/debug.rs, line 39:

<comment>Test-only inject-scope nodes are being added as regular production Debug nodes, which can mislead users and clutter the node surface with no-op scaffolding.</comment>

<file context>
@@ -34,3 +34,13 @@ fn unwrap_option<T: Default>(_: impl Ctx, #[implementations(Option<f64>, Option<
 }
+
+#[node_macro::node(category("Debug"), inject_scope)]
+fn inject_scope_test_producer(_: impl Ctx) -> bool {
+	true
+}
</file context>

[cubic-dev-ai]

1 issue found across 4 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/nodes/gcore/src/debug.rs">

<violation number="1" location="node-graph/nodes/gcore/src/debug.rs:39">
P3: Test-only inject-scope nodes are being added as regular production Debug nodes, which can mislead users and clutter the node surface with no-op scaffolding.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>