Skip to content

Fix OAuth signature generation in validateRestApiAccess #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mwalek wants to merge 4 commits into from
Closed

Fix OAuth signature generation in validateRestApiAccess #2

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b9247e
Fix OAuth signature generation in validateRestApiAccess
Mwalek Dec 30, 2025
75dccf1
Add defensive check for httpClient baseURL
Mwalek Dec 30, 2025
8911c9f
Add defaults.baseURL to MockHttpClient for test compatibility
Mwalek Dec 30, 2025
de00638
Add optional chaining for httpClient.defaults.baseURL
zackkatz Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/config/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,15 @@ export async function validateRestApiAccess(httpClient, authManager) {
{ path: '/feeds', name: 'Feeds' }
];

// Get baseURL from httpClient for OAuth signature generation
const baseURL = httpClient.defaults.baseURL;

const results = [];
for (const endpoint of endpoints) {
try {
const headers = authManager.getAuthHeaders();
// Generate proper OAuth headers with full URL for signature
const fullUrl = `${baseURL}${endpoint.path}`;
const headers = authManager.getAuthHeaders('GET', fullUrl, { per_page: 1 });
Comment thread
coderabbitai[bot] marked this conversation as resolved.
await httpClient.get(endpoint.path, {
headers,
params: { per_page: 1 }
Expand Down
Loading