chore: deploy-audit cleanup (drop stale Docker scaffolding, pin deadcode)#26
Merged
Conversation
…code eyrie is a library (no `cmd/`, no `package main` outside `examples/`, and the Makefile build target literally documents this). The repo carried a `deploy/docker/docker-compose.yml` that built a `Dockerfile` that never existed, plus a `.dockerignore` listing patterns for the absent Dockerfile. Both are removed. Removed ------- - deploy/docker/docker-compose.yml — `dockerfile: Dockerfile` with context `../../`; no Dockerfile is present. `docker compose build` fails on first invocation. eyrie ships as a Go module via `go get`; consumers embed its HTTP `api.Server` if they want to expose it. - deploy/ — directory deleted entirely (was empty after the compose file went away). - .dockerignore — vestigial; listed Dockerfile/docs/deploy/api which were either absent or are real source dirs that must NOT be excluded. Pinned ------ - .github/workflows/ci.yml: deadcode pinned to v0.30.0 (was `@latest`). Matches hawk's pin and gives reproducible CI. Validation ---------- - go build ./... — clean - go vet ./... — clean - gofumpt -l . / goimports -l . — clean - golangci-lint run --timeout=5m — 0 issues - go test ./... -short — all pass - govulncheck ./... — no vulnerabilities
Patel230
commented
Jun 10, 2026
Patel230
left a comment
Patel230
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review (cannot approve own PR): no .go source touched; only deletes a stale docker-compose + .dockerignore and pins deadcode. All 15 CI checks green. Merging.
Contributor
Author
|
Self-review: no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A deploy-readiness audit across the hawk-eco set surfaced two pieces of stale Docker scaffolding in this repo. eyrie is a Go library (no
cmd/, nopackage mainoutsideexamples/,Makefilebuild target literally says "eyrie is a library consumed by hawk; no standalone binary"), so adeploy/docker/docker-compose.ymlplus.dockerignorethat referenced a non-existentDockerfilewere misleading and broken (docker compose buildwould fail on first invocation).What changed
Removed
deploy/docker/docker-compose.yml—build.dockerfile: Dockerfilewith context../../. NoDockerfileexists anywhere in the repo (verified viafind -name 'Dockerfile*'). Consumers who want eyrie as an HTTP service embedinternal/api.Serverfrom their own daemon (hawk does this).deploy/— directory deleted entirely (was empty after the compose file went away)..dockerignore— vestigial; listedDockerfile,docs/,deploy/,api/— Dockerfile/deploy were absent, anddocs/api/are real source dirs that must not be excluded from any future build context.Pinned
.github/workflows/ci.yml—deadcodepinned tov0.30.0(was@latest). Matches hawk's pin and gives reproducible CI.Validation
All run locally on Go 1.26.4 (matches
go.mod):go build ./...go vet ./...gofumpt -l ./goimports -l .golangci-lint run --timeout=5mgo test ./... -shortgovulncheck ./...Risk
Low. No
*.gosource files modified.Follow-ups (separate PRs)
The audit also found similar stale scaffolding in tok, yaad, and hawk — those will get their own PRs. tok PR: GrayCodeAI/tok#56.