fix/deep review improvements#57
Merged
Merged
Conversation
Patel230
commented
Jun 11, 2026
Patel230
commented
Contributor
- refactor(filter): remove unused reserved layer config types
- fix(tracking): include db path and operation in wrapped errors
- docs(unsafe): add safety-invariant comments at unsafe conversions
Remove QuestionAwareLayerConfig, DensityAdaptiveLayerConfig, NumericalQuantLayerConfig, and DynamicRatioLayerConfig (all marked "reserved for future implementation") plus their never-read fields on LayerConfig. Verified unreferenced via grep across the repo. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
All error paths in tracking.go now report the database path and the operation that failed (open, create dir, init schema, enable WAL, record, aggregate, recent, scan, prune), making failures diagnosable without enabling debug logging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Each unsafe string<->[]byte conversion in internal/fastops/simd.go and internal/filter/zerocopy.go now carries an explicit "safe: ..." comment stating the aliasing invariant (backing array not mutated while the alias is live). Also migrated the legacy *(*string)(unsafe.Pointer(&b)) header-punning pattern to the supported unsafe.String/unsafe.Slice + unsafe.SliceData/StringData APIs, which are valid under the Go memory model (the old slice->string pun read a slice header as a string header). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.